Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iothub: Support Identity-Based Endpoint #14705

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Dec 22, 2021

Cont. of #14354. Adding support for identity-based authentication to custom routing endpoint of iot hub. There are four endpoint resources and the main iot_hub resource. Fix #9139

  • eventhub, servicebus_queue and servicebus_topic
    • authentication_type: whether to use keyBased(default) or identityBased
    • identity_id: user-assigned managed identity id when using identityBased
    • endpoint_uri and entity_path: set together, to specify the target endpoint in identityBased case
    • connection_string: update from Required to Optional, this is used in keyBased case
  • storage_container
    • authentication_type, identity_id, endpoint_uri, connection_string: same as above.
    • entity_path is not applicable because container_name is already used
  • iothub
    Endpoints can be specified directly on iothub, above properties are added here as well. Due to the limitation of schema in a TypeList, restrictions of these properties are put into code instead.
    Test result:
    image

@YoshicoppensE61
Copy link

can this get merged for the 2.91 milestone?

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o LGTM 🚀 !

@catriona-m catriona-m merged commit c4eb511 into hashicorp:main Jan 19, 2022
@github-actions github-actions bot added this to the v2.93.0 milestone Jan 19, 2022
catriona-m added a commit that referenced this pull request Jan 19, 2022
@myc2h6o myc2h6o deleted the iothub_routing_identity branch January 19, 2022 11:33
@github-actions
Copy link

This functionality has been released in v2.93.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for IoTHub Managed Service Identity for Endpoints
4 participants