Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v2 auth tokens (i.e. MSAL) #14403

Merged
merged 7 commits into from
Jan 28, 2022
Merged

Commits on Jan 25, 2022

  1. Configuration menu
    Copy the full SHA
    e0b8793 View commit details
    Browse the repository at this point in the history
  2. Support for v2 auth tokens (i.e. MSAL)

    - This is opt-in behaviour via the provider property `use_msal`, and
      environment variables `ARM_USE_MSAL` / `ARM_USE_MSGRAPH` (the latter
      for compatibility with the related backend property
    
    - When `use_msal` is true, do not make any API calls to a graph API
      (legacy or current). There are only 2 uses of this at present:
    
      - `data.azurerm_client_config`, which doesn't actually do anything
        with the result so this appears to be a vestige anyway
      - `azurerm_hdinsight_kafka_cluster`, the API for which requires
        both an AAD group ID and name to be specified (?) so currently
        this resource looks up the group name from the supplied ID. In
        future we'll require that both are specified (e.g. using
        `data.azuread_group` for any necessary lookup)
    
    - In v3.0, we'll remove support for graph clients in order to delegate
      any required usage to the AzureAD provider.
    
    - Also removes support for Azure Germany, which is now offline
    manicminer authored and tombuildsstuff committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    db4bce3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a3b201 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
    manicminer and tombuildsstuff committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    5e20109 View commit details
    Browse the repository at this point in the history
  5. go mod vendor

    tombuildsstuff committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    e04f89d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Configuration menu
    Copy the full SHA
    39eb654 View commit details
    Browse the repository at this point in the history
  2. Always use MSAL tokens in v3

    Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
    manicminer and tombuildsstuff committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    55e6ae6 View commit details
    Browse the repository at this point in the history