Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switching to use ID Formatters in (some) Requires Import steps #14338

Merged
merged 20 commits into from
Nov 26, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR switches to using the ID Formatter value in the Requires Import step to ensure that this is consistent (and can be used in errors etc)

This is fairly large, but each service package is scoped to a commit, so this may be worth a commit-by-commit review.

Even with this open there's another ~400 total to fix, which'll come in subsequent PR's:

$ grep -R "\*existing.ID)" ./internal/services | wc -l
288

$ grep -R "d.SetId(\*read.ID)" ./internal/services | wc -l
96

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff. Flagged several log and error messages that seem to have been forgotten and the linter is unhappy about some fmt.Errorf calls. Other than that LGTM!

internal/services/cdn/cdn_profile_resource.go Outdated Show resolved Hide resolved
internal/services/synapse/synapse_sql_pool_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_pool_resource.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@jackofallops jackofallops modified the milestones: v2.87.0, v2.88.0 Nov 26, 2021
@katbyte katbyte merged commit 2785eb6 into main Nov 26, 2021
@katbyte katbyte deleted the b/requires-import-ids branch November 26, 2021 18:44
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants