-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switching to use ID Formatters in (some) Requires Import steps #14338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tombuildsstuff. Flagged several log and error messages that seem to have been forgotten and the linter is unhappy about some fmt.Errorf
calls. Other than that LGTM!
internal/services/servicebus/servicebus_namespace_disaster_recovery_config_resource.go
Outdated
Show resolved
Hide resolved
internal/services/servicebus/servicebus_namespace_disaster_recovery_config_resource.go
Outdated
Show resolved
Hide resolved
internal/services/servicebus/servicebus_namespace_disaster_recovery_config_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏗️
This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR switches to using the ID Formatter value in the Requires Import step to ensure that this is consistent (and can be used in errors etc)
This is fairly large, but each service package is scoped to a commit, so this may be worth a commit-by-commit review.
Even with this open there's another ~400 total to fix, which'll come in subsequent PR's: