Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard_Microsoft for CDN profile SKU type #1415

Closed
wants to merge 6 commits into from
Closed

Add Standard_Microsoft for CDN profile SKU type #1415

wants to merge 6 commits into from

Conversation

IronCore864
Copy link

@IronCore864 IronCore864 commented Jun 20, 2018

Adding support to "Standard Microsoft" pricing tier.

As stated HERE in MS doc.

cdn.StandardMicrosoft added in this PR HERE

CI failing because of this, and I can't update the model in this repo because of govendor status check in makefile.

@tombuildsstuff
Copy link
Contributor

hey @IronCore864

Thanks for this PR :)

Since this value isn't available in the SDK at present - we should be able to add this as a string directly; e.g.

ValidateFunc: validation.StringInSlice([]string{
  string(cdn.StandardAkamai),
  string(cdn.StandardVerizon),
  // TODO: replace with a constant in the SDK
  "Standard_Microsoft",
  string(cdn.PremiumVerizon),
}, true),

Once that's available in the SDK - we can then switch over to using the newly available Constant/Enum. This PR otherwise LGTM, in order to get this merged can we revert the changes to the vendored SDK and add an acceptance test for this new CDN type?

Thanks!

@tombuildsstuff
Copy link
Contributor

hey @IronCore864

I hope you don't mind - but I've made the above changes in #1465 which I'm going to close this PR in favour of so that we can get this merged.

Thanks!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants