Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_storage_account_sas #1011

Merged
merged 15 commits into from
May 20, 2018
Merged

New Data Source: azurerm_storage_account_sas #1011

merged 15 commits into from
May 20, 2018

Commits on Mar 22, 2018

  1. Initial code and unit tests for Storage Account Shared Access Signatu… 

    …re support.
    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    4fa76c4 View commit details
    Browse the repository at this point in the history

  2. Unit test for SAS computation which matches the Azure Portal 

    passes.
    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    048bb76 View commit details
    Browse the repository at this point in the history

  3. Unit test for SAS computation which matches the Azure Portal 

    passes - 2
    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    d9d1dc2 View commit details
    Browse the repository at this point in the history

  4. Move SAS support from a resource to a data source.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    d59dfb1 View commit details
    Browse the repository at this point in the history

  5. Add unit tests for the string building functions.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    109629b View commit details
    Browse the repository at this point in the history

  6. Fix warnings on unused func params.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    27e8d5a View commit details
    Browse the repository at this point in the history

  7. Add unit test for the connection string parse.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    c19295d View commit details
    Browse the repository at this point in the history

  8. Make sure to set the id of the data source element.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    a1f12ee View commit details
    Browse the repository at this point in the history

  9. Make https_only an optional/defaulted field.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    66c8aca View commit details
    Browse the repository at this point in the history

  10. Add documentation for data source azurerm_storage_account_sas.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    d16f5df View commit details
    Browse the repository at this point in the history

  11. WIP: Add acceptance test.

    @jzampieron
    jzampieron committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    6088083 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Incorporate fixes from first gh review feedback. - Set force new beha… 

    …vior.
    @jzampieron
    jzampieron committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    bcbf6fb View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Fix tabs vs spaces in the hcl string literal.

    @jzampieron
    jzampieron committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    0eace11 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. Remove unnecessary validation function per github review. 

    Update documentation with more verbose field details.
    @jzampieron
    jzampieron committed May 18, 2018
    Configuration menu
    Copy the full SHA
    5bc7264 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2018

  1. data_source_storage_account_sas_test.go make test names similar

    @katbyte
    katbyte committed May 20, 2018
    Configuration menu
    Copy the full SHA
    71350a4 View commit details
    Browse the repository at this point in the history