Feature Request: Support the WriteAccelerator property on datadisks

[anandramakrishna]

Affected Resource(s)

• azurerm_compute_virtual_machine

References

See azure-sdk-for-go/services/compute/mgmt/2017-12-01/compute/models.go for information about the WriteAccelerator property.

[anandramakrishna]

@katbyte I was reviewing your PR and observed that this is set to default to "true". I don't think that's correct, as that would be a change for existing terraform deployments.

We should make the default be "false" for this .

[katbyte]

Hi @anandramakrishna,

Thank you for taking a look 🙂

Currently the property is optional, so I believe if it is left out it will be false and not enable the feature. Currently I can not fully test this PR as it is in public preview and I don't think our subscription is whitelisted, I haven't checked yet.

[anandramakrishna]

I can get your subscription whitelisted if necessary. Please let me (or others at MS) know which one.

[tombuildsstuff]

@anandramakrishna based on your message, is this functionality invite-only at this point; or can users self-register for it?

[anandramakrishna]

Let me follow-up on this. I'll get back to you.

[anandramakrishna]

I've enabled your subscription. Users will be able to use it publicly without needing whitelisting in another week (approximately).

[katbyte]

Hey @anandramakrishna,

Just wanted to provide an update: We are currently waiting for capacity on our subscription so we can test and run acceptance tests. Once we have quote and can verify everything works as expected we can merge an close this out.

[BalaAnbalagan]

Hi
Please let me know how to use it, I can test it.

[katbyte]

Hi @BAnbalagan,

Thank you for the offer but not only do we need confirm it works, we need a way to continuously test it going forward as changes are made to the resource.

[katbyte]

Hey @anandramakrishna, @BalaAnbalagan,

Just wanted to let you know this has been included in 1.7 and releases today.

[BalaAnbalagan]

Awesome

…

On Fri, Jun 15, 2018 at 8:40 PM kt ***@***.***> wrote: Hey @anandramakrishna <https://github.com/anandramakrishna>, @BalaAnbalagan <https://github.com/BalaAnbalagan>, Just wanted to let you know this has been included in 1.7 and releases today. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#959 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aj57FP3gvvZGz_Qgh9XqHDVNCZkKi-7Nks5t9H47gaJpZM4Sk5Mc> .

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!