Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_assignment - generating a name if one isn't specified #685

Merged
merged 2 commits into from
Jan 16, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Making the Name optional for a Role Assignment, and generating a name (UUID) if one isn't specified

Fixes #667

Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two comments

@@ -7,6 +7,7 @@ import (

"github.com/Azure/azure-sdk-for-go/arm/authorization"
"github.com/hashicorp/terraform/helper/schema"
"github.com/satori/uuid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using go-uuid here to stay in line with the rest of the HashiCorp ecosystem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly - the Azure SDK uses this version (and now github.com/marstr/guid) - so I picked it for internal consistency tbh; I'll update this

@@ -56,6 +58,10 @@ func resourceArmRoleAssignmentCreate(d *schema.ResourceData, meta interface{}) e
roleDefinitionId := d.Get("role_definition_id").(string)
principalId := d.Get("principal_id").(string)

if name == "" {
name = uuid.NewV1().String()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor-ish nit here, but we should be using v4 UUIDs to ensure they are as random as possible.

Tests pass:
```
 $ acctests azurerm TestAccAzureRMRoleAssignment_emptyName
=== RUN   TestAccAzureRMRoleAssignment_emptyName
--- PASS: TestAccAzureRMRoleAssignment_emptyName (19.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	19.400
```
@tombuildsstuff tombuildsstuff merged commit a681494 into master Jan 16, 2018
@tombuildsstuff tombuildsstuff deleted the role-assignment-name-optional branch January 16, 2018 09:44
tombuildsstuff added a commit that referenced this pull request Jan 16, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: automatically generate UUID for azurerm_role_assignment
2 participants