Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azurerm_database_vulnerability_assessment_rule_baseline] New resource for vulnerability scan baseline settings #3806

Merged

Conversation

benjamin37
Copy link
Contributor

@benjamin37 benjamin37 commented Jul 8, 2019

related to #4161

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benjamin37,

Thank you for this pr. Overall it looks great and i've left some mostly stylistic comments inline that once addressed & the tests pass this should be good to merge.

@katbyte katbyte modified the milestone: v1.33.0 Aug 2, 2019
@katbyte katbyte added this to the v1.33.0 milestone Aug 4, 2019
benjamin37 and others added 15 commits August 5, 2019 09:46
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
Co-Authored-By: kt <kt@katbyte.me>
…parameters that forces the resource to be recreated
@benjamin37
Copy link
Contributor Author

Hi @katbyte,

did some changes you requsted. Still not fixed the panic: Invalid address to set error, why shouldn't I call the set method to set the resource group in the read? This seems to be necessary to me. I will have an other look on this bug tomorrow!

About giving you the rights to push on the branch I will also check back tomorrow.

Kind regards
Benjamin

@ghost ghost removed the waiting-response label Dec 9, 2019
@katbyte
Copy link
Collaborator

katbyte commented Dec 9, 2019

@benjamin37, there is a bug on master right now causing acctests to fail.

As for the d.Set(), your right in that it should be required there 🤔 maybe i read the error wrong. Once we fix master we can see if its still there.

@benjamin37
Copy link
Contributor Author

Hi @katbyte,

thanks for the hint, this saved me some time :-)
I rebased against master again and run all the tests. They seem to work fine now.

Sadly I don't have the permissions to let you push on the branch of this PR.

If there is anything to do on this PR please let me know!

Kind regards
Benjamin

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamin37,

All looks good aside from i am still getting this error:

panic: Invalid address to set: []string{"resource_group_name"}

goroutine 1050 [running]:
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*ResourceData).Set(0xc0004936c0, 0x506259c, 0x13, 0x49a1b20, 0xc0017fa3a0, 0x0, 0xdf8475800)
	/Users/kt/hashi/tf/azure/azurerm/vendor/github.com/hashicorp/terraform-plugin-sdk/helper/schema/resource_data.go:193 +0x354
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmMssqlServerSecurityAlertPolicyRead(0xc0004936c0, 0x4a94d80, 0xc00073c400, 0x0, 0x0)
	/Users/kt/hashi/tf/azure/azurerm/azurerm/resource_arm_mssql_server_security_alert_policy.go:169 +0x32d

it looks like your using the wrong read function for the assessment:
image

(we use an env during tests to make additional checks (export TF_SCHEMA_PANIC_ON_ERROR=1)

@benjamin37
Copy link
Contributor Author

benjamin37 commented Dec 11, 2019

Hi @katbyte,

ups, that's obviously a bug, I changed it to use the correct read function.

Rebased against master, you can have an other look on the PR.

I've run the tests once again with the TF_SCHEMA_PANIC_ON_ERROR=1 flag. They run without error now.

Kind regards
Benjamin

@ghost ghost removed the waiting-response label Dec 11, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @benjamin37! and all your work and patience on this. LGTM now 👍

@katbyte katbyte merged commit 9107ebd into hashicorp:master Dec 12, 2019
katbyte added a commit that referenced this pull request Dec 12, 2019
@benjamin37 benjamin37 deleted the feature/db-vulnerability-scan-baseline branch December 12, 2019 08:42
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 13, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 13, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants