Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_data_factory_dataset_sql_server_table #3236

Merged
merged 7 commits into from
Apr 12, 2019

Conversation

mbfrahry
Copy link
Member

This PR adds azurerm_data_factory_dataset_sql_server_table to the Data Factory collection and starts to consolidate some of the methods used between the resources into a single source under datafactory.go

--- PASS: TestAccAzureRMDataFactoryDatasetSQLServerTable_basic (94.35s)

@mbfrahry mbfrahry requested a review from a team April 12, 2019 03:35
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mbfrahry, aside from a few comments i've left inline this LGTM 👍

azurerm/data_factory.go Outdated Show resolved Hide resolved
azurerm/data_factory.go Outdated Show resolved Hide resolved
return &annotations
}

func flattenDataFactoryAnnotations(input *[]interface{}) []string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could use utils.FlattenStringArray instead of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly enough, I think it'd be a call to utils.ExpandStringArray

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought. I think it's needed because it's an *[]interface{} and we'd need to do some finagling to get it to a []string

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yea sorry, its so close to the signature, and as much as i'd want to ask if terraform would accept the interface array i know we should check they are all strings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

@mbfrahry mbfrahry merged commit e91181a into master Apr 12, 2019
@mbfrahry mbfrahry deleted the f-data-factory-dataset branch April 12, 2019 21:12
@ghost
Copy link

ghost commented May 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants