azurerm_nginx_deployment: Add dataplane API endpoint property

[puneetsarna]

• As the property is useful for customers, it is worth exposing it as a resource attribute.
• Also updated the data source with the same property.

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[puneetsarna]

 make acctests SERVICE='nginx' TESTARGS='-run=TestAccNginxDeploymentDataSource_basic'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxDeploymentDataSource_basic -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNginxDeploymentDataSource_basic
=== PAUSE TestAccNginxDeploymentDataSource_basic
=== CONT  TestAccNginxDeploymentDataSource_basic
--- PASS: TestAccNginxDeploymentDataSource_basic (412.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx	415.395s
terraform-provider-azurerm $
terraform-provider-azurerm $
terraform-provider-azurerm $ make acctests SERVICE='nginx' TESTARGS='-run=TestAccNginxDeployment_basic'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxDeployment_basic -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNginxDeployment_basic
=== PAUSE TestAccNginxDeployment_basic
=== CONT  TestAccNginxDeployment_basic
--- PASS: TestAccNginxDeployment_basic (423.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx	425.699s

[stephybun]

Thanks @puneetsarna LGTM 👍

[stephybun]

Not important or a now problem, just mentioning it for future PRs but these should be listed in alphabetical order

[puneetsarna]

got it 👍

[puneetsarna]

quick question on this. What if certain properties are more important than the ones when listed alphabetically?

As a user of the NGINXaaS instance, I will care more about the IP address and the version of the instance rather than the dataplane endpoint. Having stuff that the users care more about listed upfront usually helps with better UX.

[stephybun]

We don't tend to consider ordering via importance of properties since this differs per resource and can also be subjective.

Properties that we consider important and are exempt from the alphabetical ordering that we try to follow and are always listed at the top are ones that are used to construct the resource's identifier and location.