r\iothub: Support managed service identity

[myc2h6o]

Fix #9139
This is required when Iot Hub needs to talk to other resources on a private v-net. Support for AuthenticatinType in routing, file upload, device import/export will be added in following prs
Test result:

[tombuildsstuff]

hi @myc2h6o

Thanks for this PR.

I've taken a look through and left some comments inline, but if we can fix those up then we can take another look.

Thanks!

[tombuildsstuff]

this'll ensure these are always removed:

Suggested change

	var identityIds map[string]*devices.ArmUserIdentity
	if len(config.UserAssignedIdentityIds) != 0 {
	identityIds = map[string]*devices.ArmUserIdentity{}
	for _, id := range config.UserAssignedIdentityIds {
	identityIds[id] = &devices.ArmUserIdentity{}
	}
	}
	identityIds = make(map[string]*devices.ArmUserIdentity, 0)
	for _, id := range config.UserAssignedIdentityIds {
	identityIds[id] = &devices.ArmUserIdentity{}
	}

[myc2h6o]

Have updated the code, but I didn't fully understand the comment, is it related to the garbage collection mechanism?

And I found that identityIds has to be nil for a SystemAssigned identity. An error will be thrown if an empty map is given. So I've updated the code to first create the ArmUserIdentity without identityIds and set it only when provided. Please check if it looks good.

[tombuildsstuff]

this is also required when it's set to SystemAssigned/UserAssigned:

Suggested change

~> **NOTE:** This is required when `type` is set to `UserAssigned`.

[myc2h6o]

Updated

[myc2h6o]

@tombuildsstuff thanks for reviewing the change. I've updated the code, please take another look.

[myc2h6o]

Rebased to latest main to resolve conflict

[myc2h6o]

Hi @tombuildsstuff I saw you added new identity types in the linked pr, I've updated this change to use the new commonschema.SystemAssignedUserAssignedIdentity() similar to #14007, please check if this looks good.

[katbyte]

Thanks @myc2h6o - LGTM 💎

[tombuildsstuff]

LGTM - thanks for pushing those changes @myc2h6o

[tombuildsstuff]

Tests pass:

[github-actions]

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.