Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configuration of keyVaultReferenceIdentity in azurerm_function_app #13960

Closed
sebader opened this issue Oct 29, 2021 · 2 comments · Fixed by #13962
Closed

Support for configuration of keyVaultReferenceIdentity in azurerm_function_app #13960

sebader opened this issue Oct 29, 2021 · 2 comments · Fixed by #13962
Labels
bug service/functions Function Apps
Milestone
v2.84.0

Comments

@sebader
Copy link
Contributor

sebader commented Oct 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • azurerm_function_app

Potential Terraform Configuration

This is a feature request to bring keyVaultReferenceIdentity which was recently implemented in #13720 also to azurerm_function_app

https://docs.microsoft.com/en-us/azure/app-service/app-service-key-vault-references
@sebader sebader mentioned this issue Oct 29, 2021
Closed
@heoelri heoelri mentioned this issue Oct 29, 2021
Merged
@katbyte katbyte added bug service/functions Function Apps labels Nov 1, 2021
katbyte pushed a commit that referenced this issue Nov 2, 2021
@heoelri
Add key_vault_reference_identity_id attribute for `azurerm_function…
b45d14b 
…_app` (#13962)

This PR adds the key_vault_reference_identity_id attribute for azurerm_function_app. Plus some test cleanup.

From the docs:

key_vault_reference_identity_id - (Optional) The User Assigned Identity Id used for looking up KeyVault secrets. The identity must be assigned to the application. See Access vaults with a user-assigned identity for more information.

Thanks to @patst for #13720. This PR will close #13960

CC: @sebader
@katbyte katbyte added this to the v2.84.0 milestone Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@petr-stupka petr-stupka mentioned this issue Nov 17, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug service/functions Function Apps
Projects
None yet
Milestone
v2.84.0
Development

Successfully merging a pull request may close this issue.

Add key_vault_reference_identity_id attribute for azurerm_function_app
2 participants
@katbyte @sebader