Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/api_management(_custom_domain): support for key_vault_certificate_id #11309

Closed
NeuroticStar opened this issue Apr 13, 2021 · 4 comments
Closed

Comments

@NeuroticStar
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • azurerm_api_management, azurerm_api_management_custom_domain

Potential Terraform Configuration

First and foremost, while mapping a custom domain to api managemetn developer and portal, I noticed few glitches with the implementation.

  1. key_vault_id under the management, developer, scm blocks should be renamed to key_vault_certificate_id
  2. As Microsoft is planning to deprecate the usage of importing certificates in key vault secrets, I would like if we provide an ability to import the certificate from azurerm_key_vault_certificate module.
@oWretch
Copy link
Contributor

oWretch commented Dec 20, 2021

Might be worth looking at for provider v3? #14193

@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Jan 6, 2022
@tombuildsstuff tombuildsstuff changed the title Support for [key vault certificate] r/api_management(_custom_domain): support for key_vault_certificate_id Mar 9, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.0.0, v3.1.0 Mar 23, 2022
@katbyte katbyte modified the milestones: v3.1.0, v3.2.0 Apr 7, 2022
@katbyte katbyte modified the milestones: v3.2.0, v3.3.0 Apr 14, 2022
@katbyte katbyte modified the milestones: v3.3.0, v3.4.0 Apr 22, 2022
@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@katbyte katbyte modified the milestones: v3.4.0, v3.5.0, v3.6.0 Apr 29, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.6.0, v3.7.0 May 17, 2022
@katbyte katbyte modified the milestones: v3.7.0, v3.8.0 May 20, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.8.0, v3.9.0, v3.10.0 May 30, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.10.0, v3.11.0 Jun 10, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.16.0, v3.17.0 Jul 31, 2022
@katbyte katbyte modified the milestones: v3.17.0, v3.18.0, v3.19.0 Aug 5, 2022
@katbyte katbyte modified the milestones: v3.19.0, v3.20.0, v3.21.0 Aug 23, 2022
@katbyte katbyte modified the milestones: v3.21.0, v3.22.0, v3.23.0 Sep 2, 2022
@katbyte katbyte modified the milestones: v3.23.0, v3.24.0, v3.25.0 Sep 16, 2022
@katbyte katbyte modified the milestones: v3.25.0, v3.26.0, v3.27..0 Sep 30, 2022
@katbyte katbyte modified the milestones: v3.27.0, v3.28.0 Oct 14, 2022
@tombuildsstuff
Copy link
Contributor

Released in v3.4.0

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants