r/key_vault: waiting for 10 successful dns locators before returnin…

…g as created

azurerm/resource_arm_key_vault.go

@@ -12,7 +12,7 @@ import (
 	"github.com/hashicorp/terraform/helper/resource"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/helper/validation"
-	uuid "github.com/satori/go.uuid"
+	"github.com/satori/go.uuid"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
 )
 
@@ -230,9 +230,18 @@ func resourceArmKeyVaultCreate(d *schema.ResourceData, meta interface{}) error {
 	if d.IsNewResource() {
 		if props := read.Properties; props != nil {
 			if vault := props.VaultURI; vault != nil {
-				err := resource.Retry(120*time.Second, checkKeyVaultDNSIsAvailable(*vault))
-				if err != nil {
-					return err
+				log.Printf("[DEBUG] Waiting for Key Vault %q (Resource Group %q) to become available", name, resGroup)
+				stateConf := &resource.StateChangeConf{
+					Pending:                   []string{"NotFound"},
+					Target:                    []string{"Found"},
+					Refresh:                   keyVaultRefreshFunc(*vault),
+					Timeout:                   30 * time.Minute,
+					MinTimeout:                15 * time.Second,
+					ContinuousTargetOccurence: 10,
+				}
+
+				if _, err := stateConf.WaitForState(); err != nil {
+					return fmt.Errorf("Error waiting for Key Vault %q (Resource Group %q) to become available: %s", name, resGroup, err)
 				}
 			}
 		}
@@ -409,19 +418,21 @@ func validateKeyVaultName(v interface{}, k string) (ws []string, errors []error)
 	return
 }
 
-func checkKeyVaultDNSIsAvailable(vaultUri string) func() *resource.RetryError {
-	return func() *resource.RetryError {
+func keyVaultRefreshFunc(vaultUri string) resource.StateRefreshFunc {
+	return func() (interface{}, string, error) {
 		uri, err := url.Parse(vaultUri)
 		if err != nil {
-			return resource.NonRetryableError(err)
+			return nil, "Failed", fmt.Errorf("Error parsing URI %q: %s", vaultUri, err)
 		}
 
-		conn, err := net.Dial("tcp", fmt.Sprintf("%s:443", uri.Host))
+		hostAndPort := fmt.Sprintf("%s:443", uri.Host)
+		conn, err := net.Dial("tcp", hostAndPort)
 		if err != nil {
-			return resource.RetryableError(err)
+			return nil, "NotFound", fmt.Errorf("Error connecting to %q: %s", hostAndPort, err)
 		}
 
 		_ = conn.Close()
-		return nil
+
+		return nil, "Found", nil
 	}
 }