Merge pull request #4597 from terraform-providers/d/devspace

r/devspace: updating to API version 2019-04-01

azurerm/internal/services/devspace/client.go

@@ -1,7 +1,7 @@
 package devspace
 
 import (
-	"github.com/Azure/azure-sdk-for-go/services/preview/devspaces/mgmt/2018-06-01-preview/devspaces"
+	"github.com/Azure/azure-sdk-for-go/services/devspaces/mgmt/2019-04-01/devspaces"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common"
 )
 

azurerm/resource_arm_devspace_controller.go

@@ -5,7 +5,7 @@ import (
 	"log"
 	"time"
 
-	"github.com/Azure/azure-sdk-for-go/services/preview/devspaces/mgmt/2018-06-01-preview/devspaces"
+	"github.com/Azure/azure-sdk-for-go/services/devspaces/mgmt/2019-04-01/devspaces"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
@@ -73,13 +73,6 @@ func resourceArmDevSpaceController() *schema.Resource {
 				},
 			},
 
-			"host_suffix": {
-				Type:         schema.TypeString,
-				Required:     true,
-				ForceNew:     true,
-				ValidateFunc: validate.NoEmptyStrings,
-			},
-
 			"target_container_host_resource_id": {
 				Type:         schema.TypeString,
 				Required:     true,
@@ -101,6 +94,11 @@ func resourceArmDevSpaceController() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+
+			"host_suffix": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 		},
 	}
 }
@@ -133,7 +131,6 @@ func resourceArmDevSpaceControllerCreate(d *schema.ResourceData, meta interface{
 
 	sku := expandDevSpaceControllerSku(d)
 
-	hostSuffix := d.Get("host_suffix").(string)
 	tarCHResId := d.Get("target_container_host_resource_id").(string)
 	tarCHCredBase64 := d.Get("target_container_host_credentials_base64").(string)
 
@@ -142,7 +139,6 @@ func resourceArmDevSpaceControllerCreate(d *schema.ResourceData, meta interface{
 		Tags:     tags.Expand(t),
 		Sku:      sku,
 		ControllerProperties: &devspaces.ControllerProperties{
-			HostSuffix:                           &hostSuffix,
 			TargetContainerHostResourceID:        &tarCHResId,
 			TargetContainerHostCredentialsBase64: &tarCHCredBase64,
 		},

azurerm/resource_arm_devspace_controller_test.go

@@ -163,7 +163,6 @@ resource "azurerm_devspace_controller" "test" {
   name                                     = "acctestdsc%d"
   location                                 = "${azurerm_resource_group.test.location}"
   resource_group_name                      = "${azurerm_resource_group.test.name}"
-  host_suffix                              = "suffix"
   target_container_host_resource_id        = "${azurerm_kubernetes_cluster.test.id}"
   target_container_host_credentials_base64 = "${base64encode(azurerm_kubernetes_cluster.test.kube_config_raw)}"
 
@@ -184,7 +183,6 @@ resource "azurerm_devspace_controller" "import" {
   name                                     = "${azurerm_devspace_controller.test.name}"
   location                                 = "${azurerm_devspace_controller.test.location}"
   resource_group_name                      = "${azurerm_devspace_controller.test.resource_group_name}"
-  host_suffix                              = "${azurerm_devspace_controller.test.host_suffix}"
   target_container_host_resource_id        = "${azurerm_kubernetes_cluster.test.id}"
   target_container_host_credentials_base64 = "${base64encode(azurerm_kubernetes_cluster.test.kube_config_raw)}"
 

go.mod

@@ -3,7 +3,6 @@ module github.com/terraform-providers/terraform-provider-azurerm
 require (
 	github.com/Azure/azure-sdk-for-go v33.2.0+incompatible
 	github.com/Azure/go-autorest/autorest v0.9.0
-	github.com/Azure/go-autorest/autorest/azure/auth v0.3.0
 	github.com/Azure/go-autorest/autorest/date v0.2.0
 	github.com/btubbs/datetime v0.1.0
 	github.com/davecgh/go-spew v1.1.1