Skip to content

Commit

Permalink
Merge pull request #5737 from terraform-providers/tph/fix-signalr
Browse files Browse the repository at this point in the history
`r/signalr_service`: updates ID to correct case
  • Loading branch information
tombuildsstuff committed Feb 14, 2020
2 parents abd8dfd + ce75a53 commit 5e9c48b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion azurerm/internal/services/signalr/parse/signalr_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func SignalRServiceID(input string) (*SignalRServiceId, error) {
ResourceGroup: id.ResourceGroup,
}

if service.Name, err = id.PopSegment("signalR"); err != nil {
if service.Name, err = id.PopSegment("SignalR"); err != nil {
return nil, err
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,20 @@ func TestSignalRServiceId(t *testing.T) {
},
{
Name: "Missing SignalR Value",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/signalR/",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/SignalR/",
Expected: nil,
},
{
Name: "SignalR Service ID",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/signalR/Service1",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/SignalR/service1",
Expected: &SignalRServiceId{
Name: "Service1",
Name: "service1",
ResourceGroup: "resGroup1",
},
},
{
Name: "Wrong Casing",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/SignalR/Service1",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.SignalRService/signalR/service1",
Expected: nil,
},
}
Expand Down

0 comments on commit 5e9c48b

Please sign in to comment.