Merge branch 'master' into automationresources

azurerm/data_source_app_service.go

@@ -4,7 +4,7 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/terraform/helper/schema"
-	azSchema "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/schema"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
 )
 
@@ -28,7 +28,7 @@ func dataSourceArmAppService() *schema.Resource {
 				Computed: true,
 			},
 
-			"site_config": azSchema.AppServiceSiteConfigSchema(),
+			"site_config": azure.SchemaAppServiceSiteConfig(),
 
 			"client_affinity_enabled": {
 				Type:     schema.TypeBool,
@@ -192,7 +192,7 @@ func dataSourceArmAppServiceRead(d *schema.ResourceData, meta interface{}) error
 		return err
 	}
 
-	siteConfig := azSchema.FlattenAppServiceSiteConfig(configResp.SiteConfig)
+	siteConfig := azure.FlattenAppServiceSiteConfig(configResp.SiteConfig)
 	if err := d.Set("site_config", siteConfig); err != nil {
 		return err
 	}

azurerm/data_source_azuread_application.go

@@ -2,10 +2,10 @@ package azurerm
 
 import (
 	"fmt"
-
 	"github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
+	"log"
 )
 
 func dataSourceArmAzureADApplication() *schema.Resource {
@@ -73,6 +73,8 @@ func dataSourceArmAzureADApplicationRead(d *schema.ResourceData, meta interface{
 	var application graphrbac.Application
 
 	if oId, ok := d.GetOk("object_id"); ok {
+
+		// use the object_id to find the Azure AD application
 		objectId := oId.(string)
 		resp, err := client.Get(ctx, objectId)
 		if err != nil {
@@ -85,13 +87,18 @@ func dataSourceArmAzureADApplicationRead(d *schema.ResourceData, meta interface{
 
 		application = resp
 	} else {
-		resp, err := client.ListComplete(ctx, "")
+
+		// use the name to find the Azure AD application
+		name := d.Get("name").(string)
+		filter := fmt.Sprintf("displayName eq '%s'", name)
+		log.Printf("[DEBUG] [data_source_azuread_application] Using filter %q", filter)
+
+		resp, err := client.ListComplete(ctx, filter)
+
 		if err != nil {
 			return fmt.Errorf("Error listing Azure AD Applications: %+v", err)
 		}
 
-		name := d.Get("name").(string)
-
 		var app *graphrbac.Application
 		for _, v := range *resp.Response().Value {
 			if v.DisplayName != nil {

azurerm/data_source_azuread_service_principal.go

@@ -2,10 +2,10 @@ package azurerm
 
 import (
 	"fmt"
-
 	"github.com/Azure/azure-sdk-for-go/services/graphrbac/1.6/graphrbac"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
+	"log"
 )
 
 func dataSourceArmActiveDirectoryServicePrincipal() *schema.Resource {
@@ -44,6 +44,8 @@ func dataSourceArmActiveDirectoryServicePrincipalRead(d *schema.ResourceData, me
 	var servicePrincipal *graphrbac.ServicePrincipal
 
 	if v, ok := d.GetOk("object_id"); ok {
+
+		//use the object_id to find the Azure AD service principal
 		objectId := v.(string)
 		app, err := client.Get(ctx, objectId)
 		if err != nil {
@@ -55,47 +57,61 @@ func dataSourceArmActiveDirectoryServicePrincipalRead(d *schema.ResourceData, me
 		}
 
 		servicePrincipal = &app
-	} else {
-		apps, err := client.ListComplete(ctx, "")
+
+	} else if _, ok := d.GetOk("display_name"); ok {
+
+		// use the display_name to find the Azure AD service principal
+		displayName := d.Get("display_name").(string)
+		filter := fmt.Sprintf("displayName eq '%s'", displayName)
+		log.Printf("[DEBUG] [data_source_azuread_service_principal] Using filter %q", filter)
+
+		apps, err := client.ListComplete(ctx, filter)
 		if err != nil {
 			return fmt.Errorf("Error listing Service Principals: %+v", err)
 		}
 
-		if v, ok := d.GetOk("display_name"); ok {
-			displayName := v.(string)
-
-			for _, app := range *apps.Response().Value {
-				if app.DisplayName == nil {
-					continue
-				}
-
-				if *app.DisplayName == displayName {
-					servicePrincipal = &app
-					break
-				}
+		for _, app := range *apps.Response().Value {
+			if app.DisplayName == nil {
+				continue
 			}
 
-			if servicePrincipal == nil {
-				return fmt.Errorf("A Service Principal with the Display Name %q was not found", displayName)
+			if *app.DisplayName == displayName {
+				servicePrincipal = &app
+				break
 			}
-		} else {
-			applicationId := d.Get("application_id").(string)
-
-			for _, app := range *apps.Response().Value {
-				if app.AppID == nil {
-					continue
-				}
-
-				if *app.AppID == applicationId {
-					servicePrincipal = &app
-					break
-				}
+		}
+
+		if servicePrincipal == nil {
+			return fmt.Errorf("A Service Principal with the Display Name %q was not found", displayName)
+		}
+
+	} else {
+
+		// use the application_id to find the Azure AD service principal
+		applicationId := d.Get("application_id").(string)
+		filter := fmt.Sprintf("appId eq '%s'", applicationId)
+		log.Printf("[DEBUG] [data_source_azuread_service_principal] Using filter %q", filter)
+
+		apps, err := client.ListComplete(ctx, filter)
+		if err != nil {
+			return fmt.Errorf("Error listing Service Principals: %+v", err)
+		}
+
+		for _, app := range *apps.Response().Value {
+			if app.AppID == nil {
+				continue
 			}
 
-			if servicePrincipal == nil {
-				return fmt.Errorf("A Service Principal for Application ID %q was not found", applicationId)
+			if *app.AppID == applicationId {
+				servicePrincipal = &app
+				break
 			}
 		}
+
+		if servicePrincipal == nil {
+			return fmt.Errorf("A Service Principal for Application ID %q was not found", applicationId)
+		}
+
 	}
 
 	d.SetId(*servicePrincipal.ObjectID)

azurerm/data_source_image.go

@@ -6,7 +6,7 @@ import (
 	"regexp"
 	"sort"
 
-	"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2017-12-01/compute"
+	"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"

azurerm/data_source_key_vault.go

@@ -5,7 +5,7 @@ import (
 
 	"github.com/Azure/azure-sdk-for-go/services/keyvault/mgmt/2016-10-01/keyvault"
 	"github.com/hashicorp/terraform/helper/schema"
-	kvschema "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/schema"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
 )
 
@@ -139,12 +139,12 @@ func dataSourceArmKeyVaultRead(d *schema.ResourceData, meta interface{}) error {
 		d.Set("enabled_for_disk_encryption", props.EnabledForDiskEncryption)
 		d.Set("enabled_for_template_deployment", props.EnabledForTemplateDeployment)
 		if err := d.Set("sku", flattenKeyVaultDataSourceSku(props.Sku)); err != nil {
-			return fmt.Errorf("Error flattening `sku` for KeyVault %q: %+v", resp.Name, err)
+			return fmt.Errorf("Error flattening `sku` for KeyVault %q: %+v", *resp.Name, err)
 		}
 
-		flattenedPolicies := kvschema.FlattenKeyVaultAccessPolicies(props.AccessPolicies)
+		flattenedPolicies := azure.FlattenKeyVaultAccessPolicies(props.AccessPolicies)
 		if err := d.Set("access_policy", flattenedPolicies); err != nil {
-			return fmt.Errorf("Error flattening `access_policy` for KeyVault %q: %+v", resp.Name, err)
+			return fmt.Errorf("Error flattening `access_policy` for KeyVault %q: %+v", *resp.Name, err)
 		}
 		d.Set("vault_uri", props.VaultURI)
 	}