feat(azuread_service_principals): Support for argument filter
#1577
+61
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofallops
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks @tiwood - Thanks for this. Just one comment to take a look at which I think will cause problems for cases that don't specify the new property if you can take a look?
Thanks!
| Description: "Use a OData filter to search for service principals.", | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Default: false, |
There was a problem hiding this comment.
I think this will need to be removed as this is a string value, not a bool?
Suggested change
| Default: false, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for filtering service principals by using a OData filter.