Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20240125.1122928 of github.com/hashicorp/go-azure-sdk/sdk and v0.66.0 of github.com/manicminer/hamilton #1298

Merged
merged 2 commits into from
Jan 29, 2024
Merged

dependencies: updating to v0.20240125.1122928 of github.com/hashicorp/go-azure-sdk/sdk and v0.66.0 of github.com/manicminer/hamilton #1298

merged 2 commits into from
Jan 29, 2024

Conversation

manicminer
Copy link
Contributor

No description provided.

@manicminer
dependencies: updating to v0.20240125.1122928 of `github.com/hashicor…
012e03f 
…p/go-azure-sdk/sdk` and v0.66.0 of `github.com/manicminer/hamilton`
tombuildsstuff
tombuildsstuff approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments around the FromParseResult function (since these need to be pointers/receiver functions) - but this otherwise LGTM 👍

internal/services/applications/parse/api_access.go Outdated
@@ -76,3 +76,17 @@ func (id ApiAccessId) Segments() []resourceids.Segment {
func (id ApiAccessId) String() string {
return fmt.Sprintf("Application API Access (Application ID: %q, API Client ID: %q)", id.ApplicationId, id.ApiClientId)
}

func (id ApiAccessId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id ApiAccessId) FromParseResult(input resourceids.ParseResult) error {
func (id *ApiAccessId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/app_role.go Outdated
@@ -76,3 +76,17 @@ func (id AppRoleId) Segments() []resourceids.Segment {
func (id AppRoleId) String() string {
return fmt.Sprintf("App Role (Application ID: %q, Role ID: %q)", id.ApplicationId, id.RoleID)
}

func (id AppRoleId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id AppRoleId) FromParseResult(input resourceids.ParseResult) error {
func (id *AppRoleId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/fallback_public_client.go Outdated
@@ -69,3 +69,13 @@ func (id FallbackPublicClientId) Segments() []resourceids.Segment {
func (id FallbackPublicClientId) String() string {
return fmt.Sprintf("Fallback Public Client (Application ID: %q)", id.ApplicationId)
}

func (id FallbackPublicClientId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id FallbackPublicClientId) FromParseResult(input resourceids.ParseResult) error {
func (id *FallbackPublicClientId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/application.go Outdated
@@ -68,3 +68,13 @@ func (id ApplicationId) Segments() []resourceids.Segment {
func (id ApplicationId) String() string {
return fmt.Sprintf("Application (Object ID: %q)", id.ApplicationId)
}

func (id ApplicationId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id ApplicationId) FromParseResult(input resourceids.ParseResult) error {
func (id *ApplicationId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/from_template.go Outdated
@@ -95,3 +95,21 @@ func (id FromTemplateId) Segments() []resourceids.Segment {
func (id FromTemplateId) String() string {
return fmt.Sprintf("Application From Template (Template ID: %q, Application ID: %q, Service Principal ID: %q)", id.TemplateId, id.ApplicationId, id.ServicePrincipalId)
}

func (id FromTemplateId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id FromTemplateId) FromParseResult(input resourceids.ParseResult) error {
func (id *FromTemplateId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/optional_claims.go Outdated
@@ -66,3 +66,13 @@ func (id OptionalClaimsId) Segments() []resourceids.Segment {
func (id OptionalClaimsId) String() string {
return fmt.Sprintf("Application Optional Claims (Application ID: %q)", id.ApplicationId)
}

func (id OptionalClaimsId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id OptionalClaimsId) FromParseResult(input resourceids.ParseResult) error {
func (id *OptionalClaimsId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/owner.go Outdated
@@ -76,3 +76,17 @@ func (id OwnerId) Segments() []resourceids.Segment {
func (id OwnerId) String() string {
return fmt.Sprintf("Application Owner (Application ID: %q, Owner ID: %q)", id.ApplicationId, id.OwnerId)
}

func (id OwnerId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id OwnerId) FromParseResult(input resourceids.ParseResult) error {
func (id *OwnerId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/permission_scope.go Outdated
@@ -76,3 +76,17 @@ func (id PermissionScopeId) Segments() []resourceids.Segment {
func (id PermissionScopeId) String() string {
return fmt.Sprintf("Permission Scope (Application ID: %q, Scope ID: %q)", id.ApplicationId, id.ScopeID)
}

func (id PermissionScopeId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id PermissionScopeId) FromParseResult(input resourceids.ParseResult) error {
func (id *PermissionScopeId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/redirect_uris.go Outdated
@@ -75,3 +75,17 @@ func (id RedirectUrisId) Segments() []resourceids.Segment {
func (id RedirectUrisId) String() string {
return fmt.Sprintf("Application Redirect URIs (Application ID: %q, URI Type: %q)", id.ApplicationId, id.UriType)
}

func (id RedirectUrisId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id RedirectUrisId) FromParseResult(input resourceids.ParseResult) error {
func (id *RedirectUrisId) FromParseResult(input resourceids.ParseResult) error {

internal/services/applications/parse/service_principal.go Outdated
@@ -68,3 +68,13 @@ func (id ServicePrincipalId) Segments() []resourceids.Segment {
func (id ServicePrincipalId) String() string {
return fmt.Sprintf("ServicePrincipal (Object ID: %q)", id.ServicePrincipalId)
}

func (id ServicePrincipalId) FromParseResult(input resourceids.ParseResult) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need to be a pointer:

Suggested change
func (id ServicePrincipalId) FromParseResult(input resourceids.ParseResult) error {
func (id *ServicePrincipalId) FromParseResult(input resourceids.ParseResult) error {

@tombuildsstuff
Copy link
Contributor

x-linking hashicorp/pandora#3601

@manicminer manicminer force-pushed the deps/go-azure-sdk-mod-split branch from 493c956 to d309d45 Compare January 29, 2024 12:34
@manicminer manicminer added this to the v2.48.0 milestone Jan 29, 2024
@manicminer manicminer force-pushed the deps/go-azure-sdk-mod-split branch from d309d45 to ddbc624 Compare January 29, 2024 12:41
@manicminer manicminer force-pushed the deps/go-azure-sdk-mod-split branch from ddbc624 to 6895f3b Compare January 29, 2024 12:43
@manicminer manicminer merged commit 432ee78 into main Jan 29, 2024
14 of 15 checks passed
@manicminer manicminer deleted the deps/go-azure-sdk-mod-split branch January 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @tombuildsstuff