Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to terraform plugin framework@v0.13.0 #685

Merged
merged 30 commits into from
Oct 3, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.
  • Combine Resource and ResourceType implementations
    • Modify associated code generation
  • Combine DataSource and DataSourceType implementations
    • Modify associated code generation
  • Changes to Provider.Configure for both resources/data sources and acceptance tests
% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_\|TestAccAWSLogsLogGroupsDataSource_' ACCTEST_PARALLELISM=3
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 3 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_\|TestAccAWSLogsLogGroupsDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroupsDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupsDataSource_basic
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroupsDataSource_basic
=== CONT  TestAccAWSLogsLogGroup_update
=== CONT  TestAccAWSLogsLogGroup_disappears
--- PASS: TestAccAWSLogsLogGroup_disappears (19.31s)
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
2022-10-03T08:36:26.681-0400 [ERROR] sdk.proto: Response contains error diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/awscc tf_proto_version=6.3 tf_rpc=ReadDataSource tf_data_source_type=awscc_logs_log_group diagnostic_detail="After attempting to read the data source, the API returned a resource not found error for the id provided. Original Error: couldn't find resource" diagnostic_severity=ERROR diagnostic_summary="AWS Data Source Not Found" tf_req_id=2a1723e7-f2f6-bbbf-c372-d01ec91a5522
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (1.25s)
=== CONT  TestAccAWSLogsLogGroup_basic
--- PASS: TestAccAWSLogsLogGroup_update (32.38s)
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
--- PASS: TestAccAWSLogsLogGroup_basic (19.55s)
--- PASS: TestAccAWSLogsLogGroupsDataSource_basic (45.08s)
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (31.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	63.997s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant