Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws-sdk-go-base #164

Merged
merged 11 commits into from
Sep 21, 2021
Merged

Update aws-sdk-go-base #164

merged 11 commits into from
Sep 21, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 17, 2021 •
edited by ewbankkit
Loading

Updates aws-sdk-go-base to v2.0.0-beta.1

Closes #144.
Closes #33.

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 20, 2021 •
edited
Loading

Can we now remove the commenting out of assume_role. tags and assume_role. transitive_tag_keys in the provider's configuration schema?

I did that.

@ewbankkit
Copy link
Contributor

  • Added validation to assume_role tags and role_arns
  • Added ability to specify assume_role tags and transitive_tag_keys

ewbankkit
ewbankkit approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison Could you please review my additional commits?

@gdavison gdavison merged commit 8379893 into main Sep 21, 2021
@ewbankkit ewbankkit deleted the update-aws-sdk-go-base branch September 21, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @ewbankkit