Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rate based rule limit for WAF #9946

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Update rate based rule limit for WAF #9946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a092ad9
Update rate based rule limit for WAF
Sep 1, 2019
1edc1bd
Update WAF documentation according to new limit
Sep 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws/resource_aws_waf_rate_based_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func resourceAwsWafRateBasedRule() *schema.Resource {
"rate_limit": {
Type: schema.TypeInt,
Required: true,
ValidateFunc: validation.IntAtLeast(2000),
ValidateFunc: validation.IntAtLeast(100),
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion aws/resource_aws_wafregional_rate_based_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func resourceAwsWafRegionalRateBasedRule() *schema.Resource {
"rate_limit": {
Type: schema.TypeInt,
Required: true,
ValidateFunc: validation.IntAtLeast(2000),
ValidateFunc: validation.IntAtLeast(100),
},
},
}
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/waf_rate_based_rule.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ resource "aws_waf_rate_based_rule" "wafrule" {
metric_name = "tfWAFRule"

rate_key = "IP"
rate_limit = 2000
rate_limit = 100

predicates {
data_id = "${aws_waf_ipset.ipset.id}"
Expand All @@ -45,7 +45,7 @@ The following arguments are supported:
* `metric_name` - (Required) The name or description for the Amazon CloudWatch metric of this rule.
* `name` - (Required) The name or description of the rule.
* `rate_key` - (Required) Valid value is IP.
* `rate_limit` - (Required) The maximum number of requests, which have an identical value in the field specified by the RateKey, allowed in a five-minute period. Minimum value is 2000.
* `rate_limit` - (Required) The maximum number of requests, which have an identical value in the field specified by the RateKey, allowed in a five-minute period. Minimum value is 100.
* `predicates` - (Optional) The objects to include in a rule (documented below).

## Nested Blocks
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/wafregional_rate_based_rule.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ resource "aws_wafregional_rate_based_rule" "wafrule" {
metric_name = "tfWAFRule"

rate_key = "IP"
rate_limit = 2000
rate_limit = 100

predicate {
data_id = "${aws_wafregional_ipset.ipset.id}"
Expand All @@ -45,7 +45,7 @@ The following arguments are supported:
* `metric_name` - (Required) The name or description for the Amazon CloudWatch metric of this rule.
* `name` - (Required) The name or description of the rule.
* `rate_key` - (Required) Valid value is IP.
* `rate_limit` - (Required) The maximum number of requests, which have an identical value in the field specified by the RateKey, allowed in a five-minute period. Minimum value is 2000.
* `rate_limit` - (Required) The maximum number of requests, which have an identical value in the field specified by the RateKey, allowed in a five-minute period. Minimum value is 100.
* `predicate` - (Optional) The objects to include in a rule (documented below).

## Nested Blocks
Expand Down