Final ACL retries

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_network_acl: Final retry after timeout deleting ACLs
* resource/aws_network_acl_rule: Final retry after timeout creating ACL rules

Output from acceptance testing:

ACL failures are not new

$ make testacc TESTARGS="-run=TestAccAWSNetworkAclRule"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSNetworkAclRule -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSNetworkAclRule_basic
=== PAUSE TestAccAWSNetworkAclRule_basic
=== RUN   TestAccAWSNetworkAclRule_disappears
=== PAUSE TestAccAWSNetworkAclRule_disappears
=== RUN   TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== PAUSE TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== RUN   TestAccAWSNetworkAclRule_missingParam
=== PAUSE TestAccAWSNetworkAclRule_missingParam
=== RUN   TestAccAWSNetworkAclRule_ipv6
=== PAUSE TestAccAWSNetworkAclRule_ipv6
=== RUN   TestAccAWSNetworkAclRule_ipv6ICMP
=== PAUSE TestAccAWSNetworkAclRule_ipv6ICMP
=== RUN   TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== PAUSE TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== RUN   TestAccAWSNetworkAclRule_allProtocol
=== PAUSE TestAccAWSNetworkAclRule_allProtocol
=== RUN   TestAccAWSNetworkAclRule_tcpProtocol
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (92.90s)
=== CONT  TestAccAWSNetworkAclRule_basic
=== CONT  TestAccAWSNetworkAclRule_ipv6ICMP
=== CONT  TestAccAWSNetworkAclRule_missingParam
=== CONT  TestAccAWSNetworkAclRule_allProtocol
=== CONT  TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== CONT  TestAccAWSNetworkAclRule_disappears
=== CONT  TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== CONT  TestAccAWSNetworkAclRule_ipv6
--- PASS: TestAccAWSNetworkAclRule_missingParam (33.39s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (50.77s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (53.67s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (53.69s)
--- PASS: TestAccAWSNetworkAclRule_disappears (54.98s)
--- PASS: TestAccAWSNetworkAclRule_basic (56.32s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (93.99s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (94.53s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       190.643s

--- FAIL: TestAccAWSNetworkAcl_EgressAndIngressRules (18.78s)
--- FAIL: TestAccAWSNetworkAcl_OnlyIngressRules_basic (21.28s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (27.10s)
--- PASS: TestAccAWSNetworkAcl_disappears (27.30s)
--- PASS: TestAccAWSNetworkAclRule_disappears (31.38s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (31.29s)
--- FAIL: TestAccAWSNetworkAcl_OnlyIngressRules_update (34.28s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (37.90s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (39.16s)
--- PASS: TestAccAWSNetworkAcl_importBasic (42.21s)
--- PASS: TestAccAWSNetworkAclRule_basic (44.16s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (44.35s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (21.25s)
--- FAIL: TestAccAWSNetworkAcl_ipv6Rules (30.40s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (25.62s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (56.67s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (57.92s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (59.86s)
--- PASS: TestAccAWSNetworkAcl_SubnetChange (60.67s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (44.09s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (68.01s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (69.53s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (38.92s)
--- PASS: TestAccAWSNetworkAcl_Subnets (75.92s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (77.38s)

[aeschright]

👍

make testacc TEST="./aws" TESTARGS="-run=TestAccAWSNetworkAcl"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSNetworkAcl -timeout 120m
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (24.81s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (23.18s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (25.66s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (25.77s)
--- FAIL: TestAccAWSNetworkAcl_OnlyIngressRules_update (26.85s)
    testing.go:568: Step 0 error: Check failed: 1 error occurred:
        	* Check 3/11 error: aws_network_acl.foos: Attribute 'ingress.401088754.protocol' expected "6", got "tcp"
        
        
--- FAIL: TestAccAWSNetworkAcl_OnlyIngressRules_basic (27.52s)
    testing.go:568: Step 0 error: Check failed: 1 error occurred:
        	* Check 2/8 error: aws_network_acl.foos: Attribute 'ingress.4245812720.protocol' expected "6", got "tcp"
        
        
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (35.55s)
--- FAIL: TestAccAWSNetworkAcl_EgressAndIngressRules (36.19s)
    testing.go:568: Step 0 error: Check failed: 2 errors occurred:
        	* Check 2/14 error: aws_network_acl.bar: Attribute 'ingress.1871939009.protocol' expected "6", got "tcp"
        	* Check 8/14 error: aws_network_acl.bar: Attribute 'egress.3111164687.protocol' expected "6", got "tcp"
        
        
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (37.59s)
--- PASS: TestAccAWSNetworkAcl_disappears (40.99s)
--- PASS: TestAccAWSNetworkAcl_importBasic (41.17s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (43.68s)
--- PASS: TestAccAWSNetworkAclRule_disappears (44.53s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (21.86s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (47.09s)
--- FAIL: TestAccAWSNetworkAcl_ipv6Rules (21.19s)
    testing.go:568: Step 0 error: Check failed: Check 3/8 error: aws_network_acl.foos: Attribute 'ingress.1976110835.protocol' expected "6", got "tcp"
--- FAIL: TestAccAWSNetworkAcl_SubnetChange (50.41s)
    testing.go:568: Step 1 error: errors during apply:
        
        Error: InvalidAssociationID.NotFound: The association ID 'aclassoc-0ee564a8ece56e756' does not exist
        	status code: 400, request id: bf257bc4-93f4-41fc-a4bf-3db7e5b05dbf
        
          on /var/folders/34/zlpt_yfn59nczyyf66xzvc240000gp/T/tf-test427070124/main.tf line 27:
          (source code not available)
        
        
--- PASS: TestAccAWSNetworkAclRule_allProtocol (51.12s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (53.73s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (28.20s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (60.82s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (61.19s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (37.67s)
--- PASS: TestAccAWSNetworkAclRule_basic (68.02s)
--- PASS: TestAccAWSNetworkAcl_Subnets (68.84s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	94.587s

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!