Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final tag retries #9821

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Final tag retries #9821

merged 1 commit into from
Aug 20, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

* tags_dynamodb: Final retries after timeouts setting dynamodb tags
* tags_sagemaker: Final retries after timeouts setting sagemaker tags

Output from acceptance testing:

$ make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws       1.264s

@ryndaniels ryndaniels requested a review from a team August 19, 2019 15:58
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Aug 19, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 19, 2019
@ryndaniels ryndaniels added this to the v2.25.0 milestone Aug 19, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 For service-wide CHANGELOG messaging, the current convention is to prefix the entries with service/X: 👍

(test failure unrelated)

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (7.64s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (3.42s)
--- PASS: TestAccAWSDynamoDbTable_disappears (25.88s)
--- PASS: TestAccAWSDynamoDbTable_basic (27.03s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (32.46s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (42.89s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (49.43s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight (23.22s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_Basic (27.56s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType (27.69s)
--- FAIL: TestAccAWSSagemakerEndpointConfiguration_Tags (32.69s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_KmsKeyId (64.50s)
--- PASS: TestAccAWSSagemakerModel_basic (27.07s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (123.40s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (134.56s)
--- PASS: TestAccAWSDynamoDbTable_importTags (137.88s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (30.92s)
--- PASS: TestAccAWSSagemakerModel_tags (34.40s)
--- PASS: TestAccAWSDynamoDbTable_encryption (136.21s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic (7.25s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (155.97s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (23.45s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (166.38s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update (12.24s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (28.47s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (48.27s)
--- PASS: TestAccAWSDynamoDbTable_tags (177.70s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (43.47s)
--- PASS: TestAccAWSSagemakerModel_containers (41.97s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (212.63s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (216.62s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (315.34s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (259.16s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (431.54s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (269.19s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (299.42s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (472.19s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (376.23s)
--- PASS: TestAccAWSSagemakerEndpoint_Tags (520.28s)
--- PASS: TestAccAWSSagemakerEndpoint_basic (533.47s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (595.93s)
--- PASS: TestAccAWSDynamoDbTable_extended (650.22s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (633.15s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (807.11s)
--- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (1028.42s)

@bflad bflad added service/dynamodb Issues and PRs that pertain to the dynamodb service. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Aug 19, 2019
@ryndaniels ryndaniels merged commit a346fef into master Aug 20, 2019
@ryndaniels ryndaniels deleted the rfd-retry-tags branch August 20, 2019 10:05
@ghost
Copy link

ghost commented Aug 23, 2019

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants