Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to import terraform aws_iam_group_policy resources #9217

Merged
merged 6 commits into from
Jul 5, 2019
Merged

Add support to import terraform aws_iam_group_policy resources #9217

merged 6 commits into from
Jul 5, 2019

Conversation

lucioveloso
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8788

Release note for CHANGELOG:

resource/aws_iam_group_policy: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMGroupPolicy_importBasic'
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSIAMGroupPolicy_importBasic
--- PASS: TestAccAWSIAMGroupPolicy_importBasic (30.81s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.845s
...

@lucioveloso lucioveloso requested a review from a team July 2, 2019 21:41
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 2, 2019
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jul 2, 2019
@lucioveloso lucioveloso changed the title Add terraform import for resource aws_iam_group_policy Add import for resource aws_iam_group_policy Jul 2, 2019
@lucioveloso lucioveloso changed the title Add import for resource aws_iam_group_policy Add support to import aws_iam_group_policy resources Jul 2, 2019
@lucioveloso lucioveloso changed the title Add support to import aws_iam_group_policy resources Add support to import terraform aws_iam_group_policy resources Jul 2, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 4, 2019
bflad
bflad suggested changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucioveloso 👋 Thanks for this contribution. I left a few feedback items below which will need to be addressed before this can be merged in. Please let us know if you have any questions or do not have time to implement the feedback items. 👍

aws/resource_aws_iam_group_policy.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy_test.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy_test.go Outdated Show resolved Hide resolved
aws/resource_aws_iam_group_policy_test.go Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Jul 4, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 4, 2019
@yamamo429 yamamo429 mentioned this pull request Jul 4, 2019
Closed
@lucioveloso
Copy link
Contributor Author

Hi @bflad. Thanks for the review/feedback. 👍I updated the code following the instructions. Please let me know if something else is needed.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 4, 2019
bflad
bflad approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the updates, @lucioveloso! LGTM, with one minor fix that will be handled on merge. 🚀

Minor test fix will be handled on merge:

--- PASS: TestAccAWSIAMGroupPolicy_disappears (10.02s)
--- PASS: TestAccAWSIAMGroupPolicy_generatedName (18.26s)
--- FAIL: TestAccAWSIAMGroupPolicy_namePrefix (18.56s)
--- PASS: TestAccAWSIAMGroupPolicy_basic (20.21s)
--- PASS: TestAccAWSIAMGroupPolicyAttachment_basic (24.31s)

aws/resource_aws_iam_group_policy_test.go Show resolved Hide resolved
@bflad bflad added this to the v2.18.0 milestone Jul 5, 2019
@bflad bflad merged commit fbdaa66 into hashicorp:master Jul 5, 2019
bflad added a commit that referenced this pull request Jul 5, 2019
@bflad
tests/resource/aws_iam_group_policy: Ignore name_prefix during import…
5b16726 
… testing

Reference: #9217 (review)

```
--- PASS: TestAccAWSIAMGroupPolicy_namePrefix (16.04s)
```
bflad added a commit that referenced this pull request Jul 5, 2019
@bflad
Update CHANGELOG for #9217
6c7a2a4
@bflad
Copy link
Contributor

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.

IAM group policy "does not support import"
2 participants
@lucioveloso @bflad