Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing of DX Gateway associations via DX Gateway import #8970

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8956

Release note for CHANGELOG:

BUG FIXES:

resource/aws_dx_gateway: Fix import of Direct Connect gateways with associations

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGateway_ -timeout 120m
=== RUN   TestAccAwsDxGateway_importBasic
=== PAUSE TestAccAwsDxGateway_importBasic
=== RUN   TestAccAwsDxGateway_importComplex
=== PAUSE TestAccAwsDxGateway_importComplex
=== RUN   TestAccAwsDxGateway_basic
=== PAUSE TestAccAwsDxGateway_basic
=== CONT  TestAccAwsDxGateway_importBasic
=== CONT  TestAccAwsDxGateway_basic
=== CONT  TestAccAwsDxGateway_importComplex
--- PASS: TestAccAwsDxGateway_basic (39.00s)
--- PASS: TestAccAwsDxGateway_importBasic (41.41s)
--- PASS: TestAccAwsDxGateway_importComplex (1741.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1741.447s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/directconnect Issues and PRs that pertain to the directconnect service. labels Jun 12, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jun 13, 2019
@bflad bflad added this to the v2.15.0 milestone Jun 13, 2019
@bflad bflad self-assigned this Jun 13, 2019
@bflad bflad modified the milestones: v2.15.0, v2.16.0 Jun 13, 2019
@bflad bflad added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label Jun 13, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit -- sorry this wasn't in the last release.

Output from acceptance testing:

--- PASS: TestAccAwsDxGateway_basic (36.37s)
--- PASS: TestAccAwsDxGateway_importBasic (37.16s)
--- PASS: TestAccAwsDxGateway_importComplex (2385.36s)

@bflad bflad merged commit 2b0f052 into hashicorp:master Jun 18, 2019
bflad added a commit that referenced this pull request Jun 18, 2019
@ewbankkit ewbankkit deleted the issue-8956 branch June 18, 2019 17:06
@ewbankkit
Copy link
Contributor Author

@bflad No problem.
Can we get #8776, fix for #8773 reviewed? There's a workaround for the issue so not super urgent.

@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/directconnect Issues and PRs that pertain to the directconnect service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dx_gateway association import throws error
2 participants