Modify Aws Backup Selection Resource #8546

teraken0509 · 2019-05-07T12:08:14Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

- resource/aws_backup_selection: Add `ForceNew` configuration for `selection_tag` attributes.
- resource/aws_backup_selection: Add resource import support.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupSelection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsBackupSelection_ -timeout 120m
=== RUN   TestAccAwsBackupSelection_basic
=== PAUSE TestAccAwsBackupSelection_basic
=== RUN   TestAccAwsBackupSelection_disappears
=== PAUSE TestAccAwsBackupSelection_disappears
=== RUN   TestAccAwsBackupSelection_withTags
=== PAUSE TestAccAwsBackupSelection_withTags
=== RUN   TestAccAwsBackupSelection_withResources
=== PAUSE TestAccAwsBackupSelection_withResources
=== RUN   TestAccAwsBackupSelection_updateTag
=== PAUSE TestAccAwsBackupSelection_updateTag
=== CONT  TestAccAwsBackupSelection_basic
=== CONT  TestAccAwsBackupSelection_withResources
=== CONT  TestAccAwsBackupSelection_updateTag
=== CONT  TestAccAwsBackupSelection_withTags
=== CONT  TestAccAwsBackupSelection_disappears
--- PASS: TestAccAwsBackupSelection_disappears (46.77s)
--- PASS: TestAccAwsBackupSelection_withResources (47.35s)
--- PASS: TestAccAwsBackupSelection_basic (47.77s)
--- PASS: TestAccAwsBackupSelection_withTags (47.89s)
--- PASS: TestAccAwsBackupSelection_updateTag (72.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	72.491s

bflad

Thanks so much, @kterada0509, looks good with two small consistency updates that will be handled on merge. 🚀

Output from AWS Standard acceptance testing:

--- PASS: TestAccAwsBackupSelection_disappears (17.90s)
--- PASS: TestAccAwsBackupSelection_basic (19.08s)
--- PASS: TestAccAwsBackupSelection_withTags (19.20s)
--- PASS: TestAccAwsBackupSelection_withResources (19.37s)
--- PASS: TestAccAwsBackupSelection_updateTag (31.67s)

bflad · 2019-05-15T15:11:25Z

aws/resource_aws_backup_selection.go

+func resourceAwsBackupSelectionImportState(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
+	idParts := strings.Split(d.Id(), "|")
+	if len(idParts) != 2 || idParts[0] == "" || idParts[1] == "" {
+		return nil, fmt.Errorf("unexpected format of ID (%q), expected <plan-id>:<selection-id>", d.Id())


The delimiter above is | not :

Suggested change

return nil, fmt.Errorf("unexpected format of ID (%q), expected <plan-id>:<selection-id>", d.Id())

return nil, fmt.Errorf("unexpected format of ID (%q), expected <plan-id>|<selection-id>", d.Id())

bflad · 2019-05-15T15:12:12Z

website/docs/r/backup_selection.html.markdown

+Backup selection can be imported using the role plan_id and id separated by `|`.
+
+```
+$ terraform import aws_backup_selection.example plan-id/selection-id


The delimiter in the import state function is | not :

Suggested change

$ terraform import aws_backup_selection.example plan-id/selection-id

$ terraform import aws_backup_selection.example plan-id|selection-id

bflad · 2019-05-15T15:13:32Z

aws/resource_aws_backup_selection_test.go

@@ -152,6 +205,31 @@ func testAccCheckAwsBackupSelectionDisappears(selection *backup.GetBackupSelecti
 	}
 }

+func testAccCheckAwsBackupSelectionRecreated(t *testing.T,


💯 Thanks for adding this.

bflad · 2019-05-17T13:46:54Z

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-03-05T14:50:29Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

teraken0509 added 2 commits May 7, 2019 21:02

Add support update selection_tag attribute and test for update

bb16009

Add support import aws_backup_selection resource

de481d7

ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 7, 2019

bflad added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. labels May 15, 2019

bflad approved these changes May 15, 2019

View reviewed changes

bflad added this to the v2.11.0 milestone May 15, 2019

bflad merged commit de481d7 into hashicorp:master May 15, 2019

bflad added a commit that referenced this pull request May 15, 2019

Update CHANGELOG for #8546

21c8258

teraken0509 deleted the feature/modify-aws_backup_selection-resource branch March 5, 2020 14:06

ghost locked and limited conversation to collaborators Mar 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify Aws Backup Selection Resource #8546

Modify Aws Backup Selection Resource #8546

teraken0509 commented May 7, 2019

bflad left a comment

bflad May 15, 2019

bflad May 15, 2019

bflad May 15, 2019

bflad commented May 17, 2019

ghost commented Mar 5, 2020

	return nil, fmt.Errorf("unexpected format of ID (%q), expected <plan-id>:<selection-id>", d.Id())
	return nil, fmt.Errorf("unexpected format of ID (%q), expected <plan-id>\|<selection-id>", d.Id())

	$ terraform import aws_backup_selection.example plan-id/selection-id
	$ terraform import aws_backup_selection.example plan-id\|selection-id

Modify Aws Backup Selection Resource #8546

Modify Aws Backup Selection Resource #8546

Conversation

teraken0509 commented May 7, 2019

Community Note

bflad left a comment

Choose a reason for hiding this comment

bflad May 15, 2019

Choose a reason for hiding this comment

bflad May 15, 2019

Choose a reason for hiding this comment

bflad May 15, 2019

Choose a reason for hiding this comment

bflad commented May 17, 2019

ghost commented Mar 5, 2020