Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adds roots attribute to the aws_organizations_organization resource #8398

Conversation

bryanlalexander
Copy link
Contributor

@bryanlalexander bryanlalexander commented Apr 21, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

As mentioned in #4207 @bflad requested the modification of the aws_organizations_organization resource to contain the response from organizations:ListRoots. This will resolve the dependency on a data source when creating an organizations_organizational_unit mentioned in #4207.

Changes proposed in this pull request:

  • adds the response from calling organizations:ListRoots to the aws_organizations_organization resource
  • updates attribute documentation on website

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSOrganizations'

=== RUN   TestAccAWSOrganizations
=== RUN   TestAccAWSOrganizations/Organization
=== RUN   TestAccAWSOrganizations/Organization/basic
=== RUN   TestAccAWSOrganizations/Organization/importBasic
=== RUN   TestAccAWSOrganizations/Organization/consolidatedBilling
=== RUN   TestAccAWSOrganizations/Account
=== RUN   TestAccAWSOrganizations/Account/basic
--- PASS: TestAccAWSOrganizations (61.00s)
    --- PASS: TestAccAWSOrganizations/Organization (60.99s)
        --- PASS: TestAccAWSOrganizations/Organization/basic (19.64s)
        --- PASS: TestAccAWSOrganizations/Organization/importBasic (22.88s)
        --- PASS: TestAccAWSOrganizations/Organization/consolidatedBilling (18.46s)
    --- PASS: TestAccAWSOrganizations/Account (0.00s)
        --- SKIP: TestAccAWSOrganizations/Account/basic (0.00s)
            resource_aws_organizations_account_test.go:20: 'TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN' not set, skipping test.
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       61.288s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 21, 2019
@bryanlalexander bryanlalexander changed the title adds roots attribute to the aws_organizations_organization resource [WIP] adds roots attribute to the aws_organizations_organization resource Apr 21, 2019
@bryanlalexander bryanlalexander force-pushed the organizations_organization_roots branch from 5bf5883 to bd4be0a Compare April 21, 2019 16:57
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 21, 2019
@bryanlalexander bryanlalexander force-pushed the organizations_organization_roots branch from bd4be0a to f0ae5c3 Compare April 21, 2019 20:36
@bryanlalexander bryanlalexander deleted the organizations_organization_roots branch April 21, 2019 20:56
@bryanlalexander bryanlalexander restored the organizations_organization_roots branch April 21, 2019 21:06
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/organizations Issues and PRs that pertain to the organizations service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant