resource/aws_network_interface: Refresh private_ips_count into Terraform state and allow updates from 0 to greater than 0 #8353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm state and allow updates from 0 to greater than 0 Reference: #3210 The Terraform 0.12 Provider SDK acceptance testing was catching that the `private_ips_count` attribute (used to signify _secondary_ private IPs) was not properly being read into the Terraform state during import. Previous output from Terraform 0.12 Provider SDK acceptance testing: ``` --- FAIL: TestAccAWSENI_importBasic (13.57s) testing.go:568: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected. (map[string]string) { } (map[string]string) (len=1) { (string) (len=17) "private_ips_count": (string) (len=1) "0" } ``` To fix this particular issue, we prefer to always read this attribute into the Terraform state during `Read`. While looking through previous bug reports for this attribute, came across a report that the resource was not properly updating the count when going from 0 to greater than 0. Added a covering acceptance test and fixed the update logic. Previous output from acceptance testing before `private_ips_count` update logic changes: ``` --- FAIL: TestAccAWSENI_PrivateIpsCount (82.51s) testing.go:568: Step 6 error: Check failed: Check 2/2 error: aws_network_interface.test: Attribute 'private_ips_count' expected "1", got "0" ``` Output from Terraform 0.11 Provider SDK acceptance testing: ``` --- PASS: TestAccAWSENI_computedIPs (33.48s) --- PASS: TestAccAWSENI_sourceDestCheck (35.03s) --- PASS: TestAccAWSENI_disappears (36.04s) --- PASS: TestAccAWSENI_basic (39.30s) --- PASS: TestAccAWSENI_updatedDescription (64.26s) --- PASS: TestAccAWSENI_PrivateIpsCount (90.29s) --- PASS: TestAccAWSENI_ignoreExternalAttachment (119.86s) --- PASS: TestAccAWSENI_attached (257.95s) ``` Output from Terraform 0.12 Provider SDK acceptance testing: ``` --- PASS: TestAccAWSENI_computedIPs (35.09s) --- PASS: TestAccAWSENI_sourceDestCheck (36.54s) --- PASS: TestAccAWSENI_disappears (37.25s) --- PASS: TestAccAWSENI_basic (39.92s) --- PASS: TestAccAWSENI_updatedDescription (64.87s) --- PASS: TestAccAWSENI_PrivateIpsCount (91.51s) --- PASS: TestAccAWSENI_ignoreExternalAttachment (121.11s) --- PASS: TestAccAWSENI_attached (261.48s) ```
bflad
added
bug
ghost
added
size/L
nywilken
reviewed
Apr 26, 2019
| } | ||
|
|
||
| // Tags | ||
| d.Set("tags", tagsToMap(eni.TagSet)) | ||
| d.Set("private_ips_count", len(eni.PrivateIpAddresses)-1) |
There was a problem hiding this comment.
Why the need to subtract 1 from the total count?
There was a problem hiding this comment.
Information documented on https://www.terraform.io/docs/providers/aws/r/network_interface.html#private_ips_count 👍
nywilken
added a commit
that referenced
this pull request
Apr 26, 2019
This was referenced May 23, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #3210
The Terraform 0.12 Provider SDK acceptance testing was catching that the
private_ips_countattribute (used to signify secondary private IPs) was not properly being read into the Terraform state during import.Previous output from Terraform 0.12 Provider SDK acceptance testing:
To fix this particular issue, we prefer to always read this attribute into the Terraform state during
Read. While looking through previous bug reports for this attribute, came across a report that the resource was not properly updating the count when going from 0 to greater than 0. Added a covering acceptance test and fixed the update logic.Previous output from acceptance testing before
private_ips_countupdate logic changes:Output from Terraform 0.11 Provider SDK acceptance testing:
Output from Terraform 0.12 Provider SDK acceptance testing: