Commits on Apr 2, 2019

1. resource/aws_cloudfront_distribution: Ignore attribute ordering of ca… …

   …che behavior forwarded values `headers` and cookies `whitelisted_names` arguments
   
   Reference: #7867
   
   Output from acceptance testing prior to code updates:
   
   ```
   --- FAIL: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (528.44s)
       testing.go:538: Step 0 error: After applying this step, the plan was not empty:
   
           DIFF:
   
           UPDATE: aws_cloudfront_distribution.test
             default_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.0: "test1" => "test2"
             default_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.1: "test2" => "test3"
             default_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.2: "test3" => "test1"
   
   --- FAIL: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (528.49s)
       testing.go:538: Step 0 error: After applying this step, the plan was not empty:
   
           DIFF:
   
           UPDATE: aws_cloudfront_distribution.test
             default_cache_behavior.0.forwarded_values.0.headers.0: "Access-Control-Request-Headers" => "Origin"
             default_cache_behavior.0.forwarded_values.0.headers.1: "Access-Control-Request-Method" => "Access-Control-Request-Headers"
             default_cache_behavior.0.forwarded_values.0.headers.2: "Origin" => "Access-Control-Request-Method"
   
   --- FAIL: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (528.46s)
       testing.go:538: Step 0 error: After applying this step, the plan was not empty:
   
           DIFF:
   
           UPDATE: aws_cloudfront_distribution.test
             ordered_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.0: "test1" => "test2"
             ordered_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.1: "test2" => "test3"
             ordered_cache_behavior.0.forwarded_values.0.cookies.0.whitelisted_names.2: "test3" => "test1"
   
   --- FAIL: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (528.43s)
       testing.go:538: Step 0 error: After applying this step, the plan was not empty:
   
           DIFF:
   
           UPDATE: aws_cloudfront_distribution.test
             ordered_cache_behavior.0.forwarded_values.0.headers.0: "Access-Control-Request-Headers" => "Origin"
             ordered_cache_behavior.0.forwarded_values.0.headers.1: "Access-Control-Request-Method" => "Access-Control-Request-Headers"
             ordered_cache_behavior.0.forwarded_values.0.headers.2: "Origin" => "Access-Control-Request-Method"
   ```
   
   Output from acceptance testing:
   
   ```
   --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (2.56s)
   --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (2.56s)
   --- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (543.49s)
   --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (544.62s)
   --- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (546.32s)
   --- PASS: TestAccAWSCloudFrontDistribution_disappears (550.45s)
   --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (580.39s)
   --- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1173.77s)
   --- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (1178.86s)
   --- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (1181.80s)
   --- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1183.92s)
   --- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1270.14s)
   --- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1270.44s)
   --- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (1268.27s)
   --- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1271.35s)
   --- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1272.23s)
   --- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (1269.96s)
   --- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1275.52s)
   --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1276.02s)
   --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1284.86s)
   --- PASS: TestAccAWSCloudFrontDistribution_Enabled (1736.60s)
   --- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1886.36s)
   ```

   

   bflad committed Apr 2, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 905e981
   • Browse repository at this point

   Copy the full SHA

   905e981 View commit details

   Browse the repository at this point in the history