Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Add QuickSight client #8148

Merged
merged 1 commit into from
Apr 2, 2019
Merged

provider: Add QuickSight client #8148

merged 1 commit into from
Apr 2, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 1, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8146

This change verifies the new AWS Go SDK client addition process after #8096

Go Modules updated via:

go test ./aws
go mod tidy
go mod vendor

@bflad
provider: Add QuickSight client
0dda224 
Reference: #8146

This change verifies the new AWS Go SDK client addition process after #8096

Go Modules updated via:

```
go test ./aws
go mod tidy
go mod vendor
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 1, 2019
@bflad bflad requested a review from a team April 1, 2019 19:28
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. labels Apr 1, 2019
tombuildsstuff
tombuildsstuff approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v2.5.0 milestone Apr 2, 2019
@bflad bflad merged commit 22041b3 into master Apr 2, 2019
@bflad bflad deleted the f-quicksightconn branch April 2, 2019 13:13
@bflad bflad added the service/quicksight Issues and PRs that pertain to the quicksight service. label Apr 2, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/quicksight Issues and PRs that pertain to the quicksight service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff