Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting endpoint for SES #7986

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Allow setting endpoint for SES #7986

merged 1 commit into from
Mar 18, 2019

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7985

Changes proposed in this pull request:

  • Add setting endpoint for SES.

Output from acceptance testing:

No tests.

@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Mar 18, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 18, 2019
@bflad bflad added this to the v2.3.0 milestone Mar 18, 2019
bflad
bflad approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀 We should probably just go ahead and do this for the other LocalStack supported endpoints, but that can be handled separately. 👍 (TravisCI failures related to #7993)

Output from acceptance testing (merely as a smoke test):

--- PASS: TestAccAWSSESDomainIdentity_disappears (8.85s)
--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (10.64s)
--- PASS: TestAccAWSSESDomainIdentity_basic (10.77s)

@bflad bflad merged commit 81766a5 into hashicorp:master Mar 18, 2019
bflad added a commit that referenced this pull request Mar 18, 2019
@bflad
Update CHANGELOG for #7986
6073737
@bflad
Copy link
Contributor

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-ses-endpoint branch March 5, 2020 14:02
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Allow setting endpoint for SES
2 participants
@teraken0509 @bflad