Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/resource/aws_api_gateway_domain_name: Additional clarification of ACM vs IAM certificate usage #7886

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 11, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6936
Closes #6635

References:

Previously, the Terraform AWS Provider did not support importing/uploading certificates into ACM. With this newer functionality, we can authoritatively point operators to the aws_acm_certificate resource.

We also try to clarify that ACM certificates should be used instead of directly uploading certificates (IAM) where ACM is supported.

Output from acceptance testing: N/A -- documentation change

…f ACM vs IAM certificate usage

References:

* #6936
* #6635
* https://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-custom-domains.html

Previously, the Terraform AWS Provider did not support importing/uploading certificates into ACM. With this newer functionality, we can authoritatively point operators to the `aws_acm_certificate` resource.

We also try to clarify that ACM certificates should be used instead of directly uploading certificates (IAM) where ACM is supported.
@bflad bflad added documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. labels Mar 11, 2019
@bflad bflad requested a review from a team March 11, 2019 12:09
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 11, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v2.2.0 milestone Mar 14, 2019
@bflad bflad merged commit 3d97258 into master Mar 14, 2019
@bflad bflad deleted the d-aws_api_gateway_domain_name-clarify-acm branch March 14, 2019 16:45
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants