Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_codebuild_webhook: Only pass BranchFilter if non-empty #7841

Merged
merged 1 commit into from
Mar 14, 2019
Merged

resource/aws_codebuild_webhook: Only pass BranchFilter if non-empty #7841

merged 1 commit into from
Mar 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 6, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7839

Previous output from acceptance testing:

--- FAIL: TestAccAWSCodeBuildWebhook_GitHub (21.97s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_codebuild_webhook.test: 1 error occurred:
        	* aws_codebuild_webhook.test: ValidationException: 1 validation error detected: Value '' at 'newProjectVersion.webhook.branches' failed to satisfy constraint: Member must have length greater than or equal to 1
        	status code: 400, request id: 83a906d9-404e-11e9-8a1d-0b0585cc888f

--- FAIL: TestAccAWSCodeBuildWebhook_Bitbucket (22.71s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_codebuild_webhook.test: 1 error occurred:
        	* aws_codebuild_webhook.test: ValidationException: 1 validation error detected: Value '' at 'newProjectVersion.webhook.branches' failed to satisfy constraint: Member must have length greater than or equal to 1
        	status code: 400, request id: 84099d6c-404e-11e9-8a1d-0b0585cc888f

--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (39.49s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (39.88s)

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildWebhook_GitHub (31.61s)
--- PASS: TestAccAWSCodeBuildWebhook_Bitbucket (34.35s)
--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (39.12s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (40.69s)

@bflad
resource/aws_codebuild_webhook: Only pass BranchFilter if non-empty
e1d14f3 
Reference: #7839

Output from acceptance testing:

```
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (31.61s)
--- PASS: TestAccAWSCodeBuildWebhook_Bitbucket (34.35s)
--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (39.12s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (40.69s)
```
@bflad bflad added bug Addresses a defect in current functionality. upstream Addresses functionality related to the cloud provider. service/codebuild Issues and PRs that pertain to the codebuild service. labels Mar 6, 2019
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 6, 2019
@bflad bflad mentioned this pull request Mar 6, 2019
Closed
nywilken
nywilken approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad marked this pull request as ready for review March 12, 2019 12:35
@bflad bflad added this to the v2.2.0 milestone Mar 14, 2019
@bflad bflad merged commit d08d62f into master Mar 14, 2019
@bflad bflad deleted the b-aws_codebuild_webhook-branch_filter-behavior-change branch March 14, 2019 16:50
bflad added a commit that referenced this pull request Mar 14, 2019
@bflad
Update CHANGELOG for #7841
96e6036
@bflad
Copy link
Contributor Author

bflad commented Mar 15, 2019

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

aws_codebuild_webhook fails if branch_filter is not set
2 participants
@bflad @nywilken