Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7466 Add security_group_id attribute to aws_directory_service_directory for ADConnector #7487

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

saravanan30erd
Copy link
Contributor

Fixes #7466

Changes proposed in this pull request:

  • Change 1
    Add security_group_id attribute to aws_directory_service_directory for ADConnector

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDirectoryServiceDirectory_connector'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSDirectoryServiceDirectory_connector -timeout 120m
=== RUN   TestAccAWSDirectoryServiceDirectory_connector
=== PAUSE TestAccAWSDirectoryServiceDirectory_connector
=== CONT  TestAccAWSDirectoryServiceDirectory_connector
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1116.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/directoryservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 9, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @saravanan30erd! 🚀

--- PASS: TestAccAWSDirectoryServiceDirectory_tags (504.11s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (518.30s)
--- PASS: TestAccAWSDirectoryServiceDirectory_importBasic (534.11s)
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (698.25s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (1015.63s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1707.54s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1851.75s)

@bflad bflad added this to the v1.59.0 milestone Feb 12, 2019
@bflad bflad merged commit 4cd3d0a into hashicorp:master Feb 12, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2019
bflad added a commit that referenced this pull request Feb 12, 2019
@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@saravanan30erd saravanan30erd deleted the issue-7466 branch February 14, 2019 23:53
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add security_group_id attribute to aws_directory_service_directory resource when using 'type = "ADConnector"'
2 participants