Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_ami: Print warning log messages for missing owners argument and missing owners filtering #5653

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 22, 2018

Reference: #5576

Changes proposed in this pull request:

  • Print warning log message for missing owners argument
  • Print warning log message for missing owners filtering completely

Verified manually:

2018/08/22 13:33:17 [WARN] The "owners" argument will become required in the next major version.
2018/08/22 13:33:17 [WARN] Documentation can be found at: https://www.terraform.io/docs/providers/aws/d/ami.html#owners
2018/08/22 13:33:17 [WARN] Potential security issue: missing "owners" filtering for AMI. Check AMI to ensure it came from trusted source.
2018/08/22 13:33:17 [DEBUG] Reading AMI: {
  Filters: [{
      Name: "name",
      Values: ["ubuntu/images/hvm-instance/ubuntu-trusty-14.04-amd64-server*"]
    },{
      Name: "root-device-type",
      Values: ["instance-store"]
    },{
      Name: "virtualization-type",
      Values: ["hvm"]
    }]
}

…gument and missing owners filtering

Verified manually:

```
2018/08/22 13:33:17 [WARN] The "owners" argument will become required in the next major version.
2018/08/22 13:33:17 [WARN] Documentation can be found at: https://www.terraform.io/docs/providers/aws/d/ami.html#owners
2018/08/22 13:33:17 [WARN] Potential security issue: missing "owners" filtering for AMI. Check AMI to ensure it came from trusted source.
2018/08/22 13:33:17 [DEBUG] Reading AMI: {
  Filters: [{
      Name: "name",
      Values: ["ubuntu/images/hvm-instance/ubuntu-trusty-14.04-amd64-server*"]
    },{
      Name: "root-device-type",
      Values: ["instance-store"]
    },{
      Name: "virtualization-type",
      Values: ["hvm"]
    }]
}
```
@bflad bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Aug 22, 2018
@bflad bflad added this to the v1.33.0 milestone Aug 22, 2018
@bflad bflad requested a review from a team August 22, 2018 17:40
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 22, 2018
@bflad bflad merged commit ae3096d into master Aug 22, 2018
@bflad bflad deleted the s-aws_ami-missing-owners-warning-log branch August 22, 2018 18:04
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants