Fix the access policy in the ES domain docs #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a resource isn't specified AWS automatically adds it to point to the ES domain it has been created for. This causes a perpetual diff where Terraform keeps attempting to remove the Resource key and AWS keeps adding it back. Also adds a note drawing attention to the fact that the values for the advanced options _must_ be strings or this will also cause a perpetual diff.
ghost
added
size/S
bflad
added
the
service/elasticsearch
|
Thanks so much @tomelliff 💯 The documentation changes here seem very appropriate for all the mentioned issues. |
This was referenced Jun 22, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource isn't specified AWS automatically adds it to point to the ES domain it has been created for.
This causes a perpetual diff where Terraform keeps attempting to remove the Resource key and AWS keeps adding it back.
Also adds a note drawing attention to the fact that the values for the advanced options must be strings or this will also cause a perpetual diff.
Fixes #576, #205, #51