-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add incremental export support for aws_dynamodb_table_export #41303
feat: Add incremental export support for aws_dynamodb_table_export #41303
Conversation
Community NoteVoting for Prioritization
For Submitters
|
ecb3734
to
aa63bc8
Compare
aa63bc8
to
8d4d0f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableExport_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableExport_' -timeout 360m -vet=off
2025/02/11 10:22:06 Initializing Terraform AWS Provider...
--- PASS: TestAccDynamoDBTableExport_s3Prefix (922.61s)
--- PASS: TestAccDynamoDBTableExport_kms (937.72s)
--- PASS: TestAccDynamoDBTableExport_basic (969.12s)
--- PASS: TestAccDynamoDBTableExport_incrementalExport (1734.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 1741.228s
Thanks for your contribution, @acwwat! 👍 |
This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR adds incremental export support to the
aws_dynamodb_table_export
resource, specifically adding theexport_type
argument and theincremental_export_specification
configuration block.Note that testing this feature is time consuming, as there needs to be at least 15 minutes of differences between
export_from_time
andexport_to_time
which starts after the table is created. In the test case, I added a 16-minute wait time to prevent 400 errors.Relations
Closes #41287
References
Referred to ExportTableToPointInTime for specs and wordings.
Output from Acceptance Testing