r/aws_rds_global_cluster: Mark `database_name` as Computed #40469

ewbankkit · 2024-12-05T20:17:57Z

Description

Prevents resource recreation when the source cluster specifies a database_name.

Relations

Closes #28187.
Closes #39368.
Relates #15916.

References

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier -timeout 720m
2024/12/05 15:21:34 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_basic
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_databaseName
--- PASS: TestAccRDSGlobalCluster_basic (15.57s)
--- PASS: TestAccRDSGlobalCluster_databaseName (25.01s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName (211.18s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (211.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	216.587s

% make testacc TESTARGS='-run=TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName' PKG=rds make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName -timeout 360m 2024/12/05 15:12:11 Initializing Terraform AWS Provider... === RUN TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName === PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName === CONT TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName --- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName (210.75s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 216.043s

github-actions · 2024-12-05T20:18:14Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

johnsonaj · 2024-12-06T14:54:32Z

@ewbankkit I keep getting pretty consistent test failures on TestAccRDSGlobalCluster_databaseName. I'm on Terraform v1.10.1.

 % make testacc TESTARGS='-run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier' PKG=rds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier -timeout 360m
2024/12/06 08:46:28 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_basic
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_databaseName
--- PASS: TestAccRDSGlobalCluster_basic (16.71s)
=== NAME  TestAccRDSGlobalCluster_databaseName
    global_cluster_test.go:169: Step 3/3 error: Error running apply: exit status 1

        Error: creating RDS Global Cluster (tf-acc-test-5160198518967250137): operation error RDS: CreateGlobalCluster, https response error StatusCode: 400, RequestID: eaf44926-ae27-4bbe-a951-8b19ded9f4bd, GlobalClusterAlreadyExistsFault: Global cluster tf-acc-test-5160198518967250137 already exists

          with aws_rds_global_cluster.test,
          on terraform_plugin_test.tf line 12, in resource "aws_rds_global_cluster" "test":
          12: resource "aws_rds_global_cluster" "test" {

--- FAIL: TestAccRDSGlobalCluster_databaseName (18.88s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (211.28s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName (220.75s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	227.188s
FAIL
make: *** [testacc] Error 1

ewbankkit · 2024-12-06T16:00:04Z

% make testacc TESTARGS='-run=TestAccRDSGlobalCluster_databaseName' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSGlobalCluster_databaseName -timeout 360m
2024/12/06 10:56:56 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== CONT  TestAccRDSGlobalCluster_databaseName
--- PASS: TestAccRDSGlobalCluster_databaseName (24.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	29.949s

It could be something to do with the parallelism as I see this failing in CI also:

=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== CONT  TestAccRDSGlobalCluster_databaseName
    global_cluster_test.go:169: Step 3/3 error: Error running apply: exit status 1
        Error: creating RDS Global Cluster (tf-acc-test-1291545954286344066): operation error RDS: CreateGlobalCluster, https response error StatusCode: 400, RequestID: 2a905d2d-607c-444a-a320-4fae5aef64e5, GlobalClusterAlreadyExistsFault: Global cluster tf-acc-test-1291545954286344066 already exists
          with aws_rds_global_cluster.test,
          on terraform_plugin_test.tf line 12, in resource "aws_rds_global_cluster" "test":
          12: resource "aws_rds_global_cluster" "test" {
--- FAIL: TestAccRDSGlobalCluster_databaseName (190.77s)

johnsonaj

LGTM 🚀

% make testacc TESTARGS='-run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier' PKG=rds AWS_DEFAULT_REGION=us-east-1

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_databaseName\|TestAccRDSGlobalCluster_SourceDBClusterIdentifier -timeout 360m
2024/12/06 10:05:07 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_basic
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName
=== CONT  TestAccRDSGlobalCluster_databaseName
--- PASS: TestAccRDSGlobalCluster_basic (13.72s)
--- PASS: TestAccRDSGlobalCluster_databaseName (21.59s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName (189.43s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (221.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	227.741s

github-actions · 2024-12-12T19:49:49Z

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2025-01-13T02:18:48Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 3 commits December 5, 2024 15:06

Add 'TestAccRDSGlobalCluster_SourceDBClusterIdentifier_databaseName'.

3b4c4c6

r/aws_rds_global_cluster: Mark database_name as Computed.

d1af32f

Correct CHANGELOG entry file name.

e9651c8

ewbankkit marked this pull request as ready for review December 5, 2024 20:26

ewbankkit requested a review from a team as a code owner December 5, 2024 20:26

ewbankkit added 3 commits December 5, 2024 15:36

Tweak documentation.

8d908e9

Merge branch 'main' into b-aws_rds_global_cluster.database_name-Computed

4b96b51

Tweak CHANGELOG entries.

c80a5cf

johnsonaj approved these changes Dec 6, 2024

View reviewed changes

ewbankkit merged commit d3045d9 into main Dec 6, 2024
42 checks passed

ewbankkit deleted the b-aws_rds_global_cluster.database_name-Computed branch December 6, 2024 16:41

github-actions bot added this to the v5.81.0 milestone Dec 6, 2024

terraform-aws-provider bot pushed a commit that referenced this pull request Dec 6, 2024

Update CHANGELOG.md for #40469

ed55343

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024

github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_rds_global_cluster: Mark `database_name` as Computed #40469

r/aws_rds_global_cluster: Mark `database_name` as Computed #40469

ewbankkit commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024

johnsonaj commented Dec 6, 2024 •

edited

Loading

ewbankkit commented Dec 6, 2024

johnsonaj left a comment

github-actions bot commented Dec 12, 2024

github-actions bot commented Jan 13, 2025

r/aws_rds_global_cluster: Mark database_name as Computed #40469

r/aws_rds_global_cluster: Mark database_name as Computed #40469

Conversation

ewbankkit commented Dec 5, 2024 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Dec 5, 2024

Community Note

johnsonaj commented Dec 6, 2024 • edited Loading

ewbankkit commented Dec 6, 2024

johnsonaj left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2024

github-actions bot commented Jan 13, 2025

r/aws_rds_global_cluster: Mark `database_name` as Computed #40469

r/aws_rds_global_cluster: Mark `database_name` as Computed #40469

ewbankkit commented Dec 5, 2024 •

edited

Loading

johnsonaj commented Dec 6, 2024 •

edited

Loading