Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semgrep errors #40273

Closed
wants to merge 1 commit into from
Closed

Fix semgrep errors #40273

wants to merge 1 commit into from

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 22, 2024

Description

Fixes ci.literal-storage_type-string-constant and ci.literal-allocated_storage-string-constant for main.

Relations

Relates #37257.

@ewbankkit ewbankkit requested a review from a team as a code owner November 22, 2024 17:12
@ewbankkit ewbankkit added linter Pertains to changes to or issues with the various linters. service/rds Issues and PRs that pertain to the rds service. labels Nov 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 22, 2024
@ewbankkit
Copy link
Contributor Author

Fixed via aa87459.

@ewbankkit ewbankkit closed this Nov 22, 2024
@ewbankkit ewbankkit deleted the td-fix-semgrep-errors branch December 20, 2024 19:02
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant