Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/route53profiles_association: Validate name field against regex #39798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jandersen-plaid
Copy link

Description

Adds a regex validation to the name argument of aws_route53profiles_association to validate that the name matches the regex expected by AWS before creating the resource.

Relations

Closes #39793

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ProfilesAssociation PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesAssociation'  -timeout 360m
2024/10/18 12:52:26 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_tags
=== PAUSE TestAccRoute53ProfilesAssociation_tags
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_tags
--- PASS: TestAccRoute53ProfilesAssociation_basic (376.25s)
--- PASS: TestAccRoute53ProfilesAssociation_disappears (392.46s)
--- PASS: TestAccRoute53ProfilesAssociation_tags (413.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles	424.106s
...

Signed-off-by: Jack Andersen <jandersen@plaid.com>
@jandersen-plaid jandersen-plaid requested a review from a team as a code owner October 18, 2024 17:00
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/route53profiles Issues and PRs that pertain to the route53profiles service. needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jandersen-plaid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/route53profiles Issues and PRs that pertain to the route53profiles service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: route53profiles_association does not validate name
2 participants