-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_s3_object (et al.): Remove kms:DescribeKey
on default S3 KMS key
#39782
Open
ewbankkit
wants to merge
11
commits into
main
Choose a base branch
from
f-aws_s3_object-no-find-default-kms-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+165
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ket'." This reverts commit 0593401.
…and 'TestAccS3Object_basicUpgrade'.
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/s3
Issues and PRs that pertain to the s3 service.
service/kms
Issues and PRs that pertain to the kms service.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
labels
Oct 17, 2024
ewbankkit
commented
Oct 17, 2024
@@ -396,10 +396,6 @@ func resourceObjectCopyRead(ctx context.Context, d *schema.ResourceData, meta in | |||
d.Set("version_id", output.VersionId) | |||
d.Set("website_redirect", output.WebsiteRedirectLocation) | |||
|
|||
if err := setObjectKMSKeyID(ctx, meta, d, aws.ToString(output.SSEKMSKeyId)); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this call above:
d.Set(names.AttrKMSKeyID, output.SSEKMSKeyId)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/kms
Issues and PRs that pertain to the kms service.
service/s3
Issues and PRs that pertain to the s3 service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the KMS call to describe the default S3 KMS key -- least privilege.
The addition of
Computed
to thekms_key_id
attribute in #15234 removed the need for this functionality.Relations
Closes #3450.
Output from Acceptance Testing