r/aws_rds_cluster_instance: Treat storage-optimization status as success when creating or updating cluster DB instances

[ewbankkit]

Description

storage-optimization should be considered as a successful state when waiting for cluster instance create and update.
The non-cluster instance resource, aws_db_instance, already has this behavior.

• https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/accessing-monitoring.html#Overview.DBInstance.Status
• https://repost.aws/knowledge-center/rds-stuck-in-storage-optimization

Relations

Closes #38497

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSClusterInstance_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSClusterInstance_ -timeout 720m
2024/10/11 13:43:15 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== RUN   TestAccRDSClusterInstance_disappears
=== PAUSE TestAccRDSClusterInstance_disappears
=== RUN   TestAccRDSClusterInstance_identifierGenerated
=== PAUSE TestAccRDSClusterInstance_identifierGenerated
=== RUN   TestAccRDSClusterInstance_identifierPrefix
=== PAUSE TestAccRDSClusterInstance_identifierPrefix
=== RUN   TestAccRDSClusterInstance_tags
=== PAUSE TestAccRDSClusterInstance_tags
=== RUN   TestAccRDSClusterInstance_isAlreadyBeingDeleted
=== PAUSE TestAccRDSClusterInstance_isAlreadyBeingDeleted
=== RUN   TestAccRDSClusterInstance_az
=== PAUSE TestAccRDSClusterInstance_az
=== RUN   TestAccRDSClusterInstance_kmsKey
=== PAUSE TestAccRDSClusterInstance_kmsKey
=== RUN   TestAccRDSClusterInstance_publiclyAccessible
=== PAUSE TestAccRDSClusterInstance_publiclyAccessible
=== RUN   TestAccRDSClusterInstance_copyTagsToSnapshot
=== PAUSE TestAccRDSClusterInstance_copyTagsToSnapshot
=== RUN   TestAccRDSClusterInstance_caCertificateIdentifier
=== PAUSE TestAccRDSClusterInstance_caCertificateIdentifier
=== RUN   TestAccRDSClusterInstance_monitoringInterval
=== PAUSE TestAccRDSClusterInstance_monitoringInterval
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
=== RUN   TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
=== CONT  TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSClusterInstance_monitoringInterval
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
=== CONT  TestAccRDSClusterInstance_az
--- PASS: TestAccRDSClusterInstance_monitoringInterval (1668.50s)
=== CONT  TestAccRDSClusterInstance_identifierPrefix
--- PASS: TestAccRDSClusterInstance_basic (793.55s)
=== CONT  TestAccRDSClusterInstance_isAlreadyBeingDeleted
--- PASS: TestAccRDSClusterInstance_az (793.60s)
=== CONT  TestAccRDSClusterInstance_tags
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1 (794.16s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
--- PASS: TestAccRDSClusterInstance_identifierPrefix (1350.48s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
--- PASS: TestAccRDSClusterInstance_isAlreadyBeingDeleted (1374.61s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled (1497.00s)
=== CONT  TestAccRDSClusterInstance_copyTagsToSnapshot
--- PASS: TestAccRDSClusterInstance_tags (1517.38s)
=== CONT  TestAccRDSClusterInstance_caCertificateIdentifier
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql (1413.05s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1 (1412.92s)
=== CONT  TestAccRDSClusterInstance_publiclyAccessible
--- PASS: TestAccRDSClusterInstance_copyTagsToSnapshot (1412.28s)
=== CONT  TestAccRDSClusterInstance_identifierGenerated
--- PASS: TestAccRDSClusterInstance_caCertificateIdentifier (1512.17s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled (1503.11s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
--- PASS: TestAccRDSClusterInstance_identifierGenerated (1440.63s)
=== CONT  TestAccRDSClusterInstance_kmsKey
--- PASS: TestAccRDSClusterInstance_publiclyAccessible (1569.81s)
=== CONT  TestAccRDSClusterInstance_disappears
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved (1781.63s)
=== CONT  TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql (1260.60s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
--- PASS: TestAccRDSClusterInstance_disappears (1420.59s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
--- PASS: TestAccRDSClusterInstance_kmsKey (1490.40s)
--- PASS: TestAccRDSClusterInstance_performanceInsightsRetentionPeriod (1596.67s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey (959.07s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey (1328.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	7637.820s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

[github-actions]

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!