Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Reduce schema memory usage by 36.2 MB (69.5%) #39652

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 9, 2024

Description

Reduce schema memory usage by approximately 36.2 MB (69.5%). Was 52.1 MB, now 15.9 MB. Also eliminates approximately 241,700 memory allocations, from 330,000 to 88,300.

Iterations Time per Operation Bytes per Operation Allocations per Operation
Before BenchmarkSDKProviderInitialization-10 46 23556856 ns/op 52104366 B/op 329982 allocs/op
After BenchmarkSDKProviderInitialization-10 148 8026065 ns/op 15936769 B/op 88261 allocs/op

@gdavison gdavison requested a review from a team as a code owner October 9, 2024 21:39
Copy link

github-actions bot commented Oct 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccQuickSightDashboard_' PKG=quicksight
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/quicksight/... -v -count 1 -parallel 20  -run=TestAccQuickSightDashboard_ -timeout 360m
2024/10/10 08:12:32 Initializing Terraform AWS Provider...
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_disappears
=== CONT  TestAccQuickSightDashboard_sourceEntity
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (39.99s)
--- PASS: TestAccQuickSightDashboard_basic (40.30s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (42.90s)
--- PASS: TestAccQuickSightDashboard_disappears (43.54s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (92.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	96.941s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.576s [no tests to run]

@gdavison gdavison merged commit 68730b2 into main Oct 15, 2024
35 checks passed
@gdavison gdavison deleted the td-quicksight-schema-memory-usage branch October 15, 2024 18:52
@github-actions github-actions bot added this to the v5.72.0 milestone Oct 15, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Pertains to changes to or issues with the various linters. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants