-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: Reduce schema memory usage by 36.2 MB (69.5%) #39652
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccQuickSightDashboard_' PKG=quicksight
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run=TestAccQuickSightDashboard_ -timeout 360m
2024/10/10 08:12:32 Initializing Terraform AWS Provider...
=== RUN TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT TestAccQuickSightDashboard_basic
=== CONT TestAccQuickSightDashboard_updateVersionNumber
=== CONT TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT TestAccQuickSightDashboard_disappears
=== CONT TestAccQuickSightDashboard_sourceEntity
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (39.99s)
--- PASS: TestAccQuickSightDashboard_basic (40.30s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (42.90s)
--- PASS: TestAccQuickSightDashboard_disappears (43.54s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (92.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 96.941s
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema 0.576s [no tests to run]
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Reduce schema memory usage by approximately 36.2 MB (69.5%). Was 52.1 MB, now 15.9 MB. Also eliminates approximately 241,700 memory allocations, from 330,000 to 88,300.