Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamodb_table: add on_demand_throughput attribute #37799

Merged
merged 21 commits into from
Oct 14, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jun 1, 2024

Description

Relations

Closes #37256

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDynamoDBTable_onDemandThroughput PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_onDemandThroughput'  -timeout 360m
=== RUN   TestAccDynamoDBTable_onDemandThroughput
=== PAUSE TestAccDynamoDBTable_onDemandThroughput
=== CONT  TestAccDynamoDBTable_onDemandThroughput
--- PASS: TestAccDynamoDBTable_onDemandThroughput (63.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	74.615s

--- PASS: TestAccDynamoDBTable_disappears (154.03s)
--- PASS: TestAccDynamoDBTable_basic (183.30s)
--- PASS: TestAccDynamoDBTable_tableClassExplicitDefault (224.39s)
--- PASS: TestAccDynamoDBTable_deletion_protection (266.47s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges (275.32s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (282.51s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (292.22s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (292.32s)
--- PASS: TestAccDynamoDBTable_enablePITR (298.29s)
--- PASS: TestAccDynamoDBTable_tableClass_ConcurrentModification (299.83s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (131.19s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (315.47s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (208.53s)
--- PASS: TestAccDynamoDBTable_extended (382.05s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (113.24s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (166.63s)
--- PASS: TestAccDynamoDBTable_onDemandThroughput (392.48s)
--- PASS: TestAccDynamoDBTable_importTable (214.31s)
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (8.73s)
--- PASS: TestAccDynamoDBTable_tableClass_migrate (147.62s)
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (600.15s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (337.01s)
--- PASS: TestAccDynamoDBTable_backupEncryption (364.31s)
--- PASS: TestAccDynamoDBTable_tags (99.96s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (165.66s)
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (440.18s)
--- PASS: TestAccDynamoDBTable_Replica_singleCMK (349.93s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (516.40s)
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (49.00s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (790.16s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (793.80s)
--- PASS: TestAccDynamoDBTable_streamSpecification (205.02s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (209.08s)
--- PASS: TestAccDynamoDBTable_Replica_singleStreamSpecification (431.40s)
--- PASS: TestAccDynamoDBTable_Replica_pitr (619.79s)
--- PASS: TestAccDynamoDBTable_streamSpecificationDiffs (376.67s)
--- PASS: TestAccDynamoDBTable_encryption (272.57s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (1013.51s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges (1024.09s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (1024.81s)
--- PASS: TestAccDynamoDBTable_Replica_singleDefaultKeyEncrypted (706.47s)
--- PASS: TestAccDynamoDBTable_Replica_tagsUpdate (1110.48s)
--- PASS: TestAccDynamoDBTable_Replica_single (901.91s)
--- PASS: TestAccDynamoDBTable_Replica_tagsNext (948.87s)
--- PASS: TestAccDynamoDBTable_Replica_pitrKMS (919.26s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (633.47s)
...

Copy link

github-actions bot commented Jun 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Jun 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 1, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 1, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2024
@johnsonaj johnsonaj self-assigned this Oct 11, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 11, 2024
@johnsonaj johnsonaj assigned johnsonaj and unassigned johnsonaj Oct 11, 2024
@johnsonaj johnsonaj changed the title R/aws dynamodb table r/aws_dynamodb_table: add on_demand_throughput attribute Oct 14, 2024
@johnsonaj johnsonaj requested a review from a team as a code owner October 14, 2024 19:52
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccDynamoDBTable_gsi\|TestAccDynamoDBTable_onDemandThroughput\|TestAccDynamoDBTable_basic\|TestAccDynamoDBTable_disappears' PKG=dynamodb

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=TestAccDynamoDBTable_gsi\|TestAccDynamoDBTable_onDemandThroughput\|TestAccDynamoDBTable_basic\|TestAccDynamoDBTable_disappears -timeout 360m
2024/10/14 14:26:35 Initializing Terraform AWS Provider...
--- PASS: TestAccDynamoDBTable_disappears (23.46s)
--- PASS: TestAccDynamoDBTable_basic (26.40s)
--- PASS: TestAccDynamoDBTable_gsiOnDemandThroughput (58.09s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (58.90s)
--- PASS: TestAccDynamoDBTable_onDemandThroughput (60.09s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (338.55s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (668.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	674.272s

@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit f01c7f5 into hashicorp:main Oct 14, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.72.0 milestone Oct 14, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_dynamodb_table: Support On-Demand Throughput
3 participants