Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for default_tags and tags on EC2 block devices #37441

Merged
merged 18 commits into from
Oct 9, 2024

Conversation

0xkag
Copy link

@0xkag 0xkag commented May 10, 2024

Description

default_tags support for EC2 root block devices was introduced in #33769, which is great ... except it makes the mix of default_tags and tags on a root_block_device perpetually showing drift even when there is none.

The solution is to not remove the default tags config from the volume tags in ec2_instance.

This diff fixes #36448 for us in our environment (which references #33769 as the change that introduced this bug).

This diff possibly fixes #36706 too, but we weren't hitting this issue.

Relations

Relates #33769
Relates #36706
Closes #36448

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2 PKG=ec2
<in progress>

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 10, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @0xkag 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024
@0xkag
Copy link
Author

0xkag commented May 22, 2024

Any interest in merging this?

@jpriebe
Copy link

jpriebe commented Jun 28, 2024

Please review this MR. We have constant noise in hundreds of plans, making us waste time reviewing plans even when there are no real changes.

@pppgithub1
Copy link

Please, review the PR. It's so annoying those bugs appearing constantly. Thanks!

@iodeslykos
Copy link

@justinretzolk @ewbankkit @jar-b Why is this being ignored? This issue is breaking our automation.

@davidlawson83
Copy link

Would be great to get this approved and merged as it's causing us noise in our plans. What's the hold up?

@sahaqaa
Copy link

sahaqaa commented Aug 12, 2024

Would be great to get this approved and merged as it's causing us noise in our plans.

@bootswithdefer
Copy link
Contributor

@0xkag Could you resolve the conflicts so we can hopefully get some maintainer eyes on this?

@0xkag 0xkag force-pushed the b-fix-erroneous-ec2-volume-drift branch from add7648 to 4c18648 Compare August 23, 2024 22:13
@0xkag 0xkag requested a review from a team as a code owner August 23, 2024 22:13
@0xkag
Copy link
Author

0xkag commented Aug 24, 2024

I resolved the conflicts. (Inevitable when a patch sits for a while.) It would be nice to get this merged; it's a very simple patch.

@sahaqaa
Copy link

sahaqaa commented Aug 29, 2024

Would be great to get this approved and merged as it's causing us noise in our plans. This PR needs some love and attention ;-)

@malcolmhancock-rldatix
Copy link

Would be great to have this bug fixed. False changes being flagged constantly is very problematic when pushing changes to production. At this point I am considering reverting to console tagging root blocks, as a less tedious option...

@ioriomauro
Copy link

Please approve this as fast as possible. Constant false drifts are a nightmare!

@Sebbo94BY
Copy link

The related issue and this solution here should be higher prioritized as it breaks automations and makes every Terraform rollout a way more complicated and time consuming as it always shows hundred of unexpected changes, which are no changes as they are already applied.

Could you please take a look at this issue as soon as possible, @breathingdust ? Many people would thank you very much for that! Thank you in advance! ❤️

Cc: @marcosentino, @justinretzolk

@sahaqaa
Copy link

sahaqaa commented Sep 27, 2024

I hope someone will review it and it will be merged in somewhat not so distant future.
It feels like it takes so much longer time then it should :-(

@Svaillan
Copy link

Svaillan commented Oct 4, 2024

bad meme 1

@YakDriver YakDriver self-assigned this Oct 7, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 7, 2024
`default_tags` support for EC2 root block devices was introduced in
hasicorp/terraform-provider-aws#33769, which is great ... except it
makes the mix of `default_tags` and `tags` on a `root_block_device`
perpetually showing drift even when there is none.

The solution is to not remove the default tags config from the volume
tags in ec2_instance.

This diff fixes hashicorp#36448 for us in our
environment (which references hashicorp#33769 as
the change that introduced this bug).

This diff possibly fixes hashicorp#36706 too, but
we weren't hitting this issue.
@YakDriver YakDriver force-pushed the b-fix-erroneous-ec2-volume-drift branch from 4c18648 to 323e790 Compare October 7, 2024 18:23
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xkag Thank you for your work on this!

Tentative Approval

I am tentatively approving this change. However, due to the critical nature of the resource, we carefully evaluate all modifications. One of the main challenges in this area is that a fix for one set of issues can sometimes cause a separate set of problems, and we work hard to prevent that. I'm seeing errors in the tests below and need to determine if a) the tests are wrong, or b) this change is not entirely correct.

I will continue investigating this change and let you know. If you have more input, especially on failing tests, continue the conversation below. Ideally, I’d also like to add a test that reproduces the issues this change addresses.

% make t T=TestAccEC2Instance_BlockDeviceTags K=ec2                
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_BlockDeviceTags'  -timeout 360m
=== RUN   TestAccEC2Instance_BlockDeviceTags_volumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_volumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== PAUSE TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== RUN   TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== NAME  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
    ec2_instance_test.go:1593: Step 1/5 error: Check failed: Check 5/10 error: aws_instance.test: Attribute 'root_block_device.0.tags.%' expected "0", got "1"
=== NAME  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
    ec2_instance_test.go:1669: Step 1/4 error: Check failed: Check 5/10 error: aws_instance.test: Attribute 'root_block_device.0.tags.%' expected "0", got "1"
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (112.42s)
--- FAIL: TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags (115.56s)
--- FAIL: TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot (125.90s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (133.11s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_attachedVolume (172.48s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	177.856s
FAIL
make: *** [t] Error 1
% make t T=TestAccEC2Instance_tags K=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_tags'  -timeout 360m
=== RUN   TestAccEC2Instance_tags
=== PAUSE TestAccEC2Instance_tags
=== RUN   TestAccEC2Instance_tags_null
=== PAUSE TestAccEC2Instance_tags_null
=== RUN   TestAccEC2Instance_tags_EmptyMap
=== PAUSE TestAccEC2Instance_tags_EmptyMap
=== RUN   TestAccEC2Instance_tags_AddOnUpdate
=== PAUSE TestAccEC2Instance_tags_AddOnUpdate
=== RUN   TestAccEC2Instance_tags_EmptyTag_OnCreate
=== PAUSE TestAccEC2Instance_tags_EmptyTag_OnCreate
=== RUN   TestAccEC2Instance_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccEC2Instance_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccEC2Instance_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccEC2Instance_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccEC2Instance_tags_DefaultTags_providerOnly
=== PAUSE TestAccEC2Instance_tags_DefaultTags_providerOnly
=== RUN   TestAccEC2Instance_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccEC2Instance_tags_DefaultTags_nonOverlapping
=== RUN   TestAccEC2Instance_tags_DefaultTags_overlapping
=== PAUSE TestAccEC2Instance_tags_DefaultTags_overlapping
=== RUN   TestAccEC2Instance_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Instance_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Instance_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Instance_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Instance_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccEC2Instance_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccEC2Instance_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccEC2Instance_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccEC2Instance_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccEC2Instance_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccEC2Instance_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccEC2Instance_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccEC2Instance_tags_ComputedTag_OnCreate
=== PAUSE TestAccEC2Instance_tags_ComputedTag_OnCreate
=== RUN   TestAccEC2Instance_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccEC2Instance_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccEC2Instance_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccEC2Instance_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccEC2Instance_tags
=== CONT  TestAccEC2Instance_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Instance_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccEC2Instance_tags_AddOnUpdate
=== CONT  TestAccEC2Instance_tags_EmptyMap
=== CONT  TestAccEC2Instance_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccEC2Instance_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccEC2Instance_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccEC2Instance_tags_DefaultTags_overlapping
=== CONT  TestAccEC2Instance_tags_null
=== CONT  TestAccEC2Instance_tags_DefaultTags_nonOverlapping
=== CONT  TestAccEC2Instance_tags_DefaultTags_providerOnly
=== CONT  TestAccEC2Instance_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccEC2Instance_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccEC2Instance_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccEC2Instance_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Instance_tags_ComputedTag_OnCreate
=== CONT  TestAccEC2Instance_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccEC2Instance_tags_EmptyTag_OnCreate
--- PASS: TestAccEC2Instance_tags_DefaultTags_nullOverlappingResourceTag (76.18s)
--- PASS: TestAccEC2Instance_tags_ComputedTag_OnCreate (117.49s)
--- PASS: TestAccEC2Instance_tags_EmptyTag_OnUpdate_Replace (119.28s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_nullNonOverlappingResourceTag (122.57s)
--- PASS: TestAccEC2Instance_tags_EmptyTag_OnUpdate_Add (124.29s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_overlapping (129.72s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_emptyProviderOnlyTag (132.11s)
--- PASS: TestAccEC2Instance_tags_EmptyMap (135.69s)
--- PASS: TestAccEC2Instance_tags_EmptyTag_OnCreate (135.99s)
--- PASS: TestAccEC2Instance_tags_ComputedTag_OnUpdate_Replace (136.17s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_emptyResourceTag (137.31s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_nonOverlapping (137.65s)
--- PASS: TestAccEC2Instance_tags_null (155.47s)
--- PASS: TestAccEC2Instance_tags_AddOnUpdate (165.41s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_updateToResourceOnly (165.87s)
--- PASS: TestAccEC2Instance_tags_ComputedTag_OnUpdate_Add (167.10s)
--- PASS: TestAccEC2Instance_tags (169.02s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_updateToProviderOnly (169.24s)
--- PASS: TestAccEC2Instance_tags_DefaultTags_providerOnly (174.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	179.784s

@YakDriver
Copy link
Member

YakDriver commented Oct 8, 2024

Update:

There are two changes here. The first is to not remove default tags from volume tags. This seems like a no-brainer yes. Volume tags do not have the tags/tags_all dynamic so they're a bit odd, in more ways than one, and shouldn't have default tags removed. Volume tags have the same issue as the other block device tags: overlaps are non-trivial. Whether to remove the merged default tags from volume tags depends on the configuration and whether they were defined in both.

The second change introduces some more of the same drama. It's bad for a quick fix but, perhaps, great for TV? The problem here is that this simple fix, albeit appealing in its simplicity, introduces problems. root_block_device and ebs_block_device have the tags/tags_all dynamic similar to the top-level of many resources. As such, they should behave the same way as when at the top-level: tags doesn't include default tags and tags_all does.

This would all be very simple if there wasn't the possibility of overlap and that's where things currently fall apart. Right now, here's what happens. If ebd (or rbd) tags have, for instance, tag pairs A, B, C, and D and default tags define C, D, E, and F, the overly simplistic RemoveDefaultConfig() leaves A and B while getting rid of C and D, because they're in the default tags. Because they're also in the tags config, we get a perpetual diff. This exact type of thing used to happen with resources (fixed with blood, sweat, and tears by Adrian Johnson 👍). The resolution requires a deeper look at the config, state, and plan. Just looking at tag information, without this deeper look, there is no way to tell if the overlapping tags should be left alone because, in fact, they appear that way in the configuration or if they should be removed as an artifact of the provider's merging of tags. Thus, more is needed to fix the problem than simply not removing the default tags.

In summary, here are the three approaches we've discussed:

  1. Currently, overlapping (i.e., duplicate) tags defined in both default tags and ebd (or rbd) tags will be removed from tags in Read leading to perpetual diffs. This is bad.
  2. The initial change proposed in this PR is to simply not remove default tags from ebd (or rbd) tags. This does fix the overlapping tags problem but at the cost of making ebd (or rbd) tags and tags_all behave differently than all the other places we have tags and tags_all throughout the provider.
  3. We need to take a deeper look at the config, state, and plan to properly handle tags and tags_all so that duplicates aren't removed when they shouldn't be, to avoid causing perpetual diffs.

@YakDriver
Copy link
Member

After some fixes...

% make t T=TestAccEC2Instance_BlockDeviceTags K=ec2                             
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_BlockDeviceTags'  -timeout 360m
=== RUN   TestAccEC2Instance_BlockDeviceTags_volumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_volumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== PAUSE TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== RUN   TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
=== CONT  TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap (102.24s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot (106.03s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (114.90s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap (130.75s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (154.98s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_attachedVolume (171.99s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags (187.67s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps (309.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	314.682s

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc TESTARGS='-run=TestAccVPCVPC_tags' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCVPC_tags -timeout 360m
--- PASS: TestAccVPCVPC_tags_DefaultTags_nullNonOverlappingResourceTag (57.23s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_nullOverlappingResourceTag (57.23s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_emptyResourceTag (57.24s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_emptyProviderOnlyTag (57.41s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnCreate (57.64s)
--- PASS: TestAccVPCVPC_tags_EmptyMap (65.58s)
--- PASS: TestAccVPCVPC_tags_null (66.54s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_updateToResourceOnly (78.13s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnUpdate_Replace (78.56s)
--- PASS: TestAccVPCVPC_tags_AddOnUpdate (81.31s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_updateToProviderOnly (82.40s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnUpdate_Add (83.01s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnUpdate_Replace (83.34s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnCreate (86.59s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnUpdate_Add (97.41s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_nonOverlapping (106.05s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_overlapping (106.09s)
--- PASS: TestAccVPCVPC_tags (122.46s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_providerOnly (122.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	129.176s

@YakDriver
Copy link
Member

YakDriver commented Oct 9, 2024

Due to crucial role of tagging and that this change could affect tags provider wide, additional testing:

% make t T=TestAccEC2InstanceDataSource_tags K=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceDataSource_tags'  -timeout 360m
=== RUN   TestAccEC2InstanceDataSource_tags
=== PAUSE TestAccEC2InstanceDataSource_tags
=== RUN   TestAccEC2InstanceDataSource_tags_NullMap
=== PAUSE TestAccEC2InstanceDataSource_tags_NullMap
=== RUN   TestAccEC2InstanceDataSource_tags_EmptyMap
=== PAUSE TestAccEC2InstanceDataSource_tags_EmptyMap
=== CONT  TestAccEC2InstanceDataSource_tags
=== CONT  TestAccEC2InstanceDataSource_tags_EmptyMap
=== CONT  TestAccEC2InstanceDataSource_tags_NullMap
--- PASS: TestAccEC2InstanceDataSource_tags_NullMap (55.26s)
--- PASS: TestAccEC2InstanceDataSource_tags (96.04s)
--- PASS: TestAccEC2InstanceDataSource_tags_EmptyMap (309.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	315.304s
% make t T=TestAccVPCRouteTableDataSource_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableDataSource_tags'  -timeout 360m
=== RUN   TestAccVPCRouteTableDataSource_tags
=== PAUSE TestAccVPCRouteTableDataSource_tags
=== RUN   TestAccVPCRouteTableDataSource_tags_NullMap
=== PAUSE TestAccVPCRouteTableDataSource_tags_NullMap
=== RUN   TestAccVPCRouteTableDataSource_tags_EmptyMap
=== PAUSE TestAccVPCRouteTableDataSource_tags_EmptyMap
=== CONT  TestAccVPCRouteTableDataSource_tags
=== CONT  TestAccVPCRouteTableDataSource_tags_EmptyMap
=== CONT  TestAccVPCRouteTableDataSource_tags_NullMap
--- PASS: TestAccVPCRouteTableDataSource_tags_NullMap (20.88s)
--- PASS: TestAccVPCRouteTableDataSource_tags (20.89s)
--- PASS: TestAccVPCRouteTableDataSource_tags_EmptyMap (20.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	26.309s
% make t T=TestAccVPCRouteTable_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTable_tags'  -timeout 360m
=== RUN   TestAccVPCRouteTable_tags
=== PAUSE TestAccVPCRouteTable_tags
=== RUN   TestAccVPCRouteTable_tags_null
=== PAUSE TestAccVPCRouteTable_tags_null
=== RUN   TestAccVPCRouteTable_tags_EmptyMap
=== PAUSE TestAccVPCRouteTable_tags_EmptyMap
=== RUN   TestAccVPCRouteTable_tags_AddOnUpdate
=== PAUSE TestAccVPCRouteTable_tags_AddOnUpdate
=== RUN   TestAccVPCRouteTable_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCRouteTable_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_overlapping
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCRouteTable_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCRouteTable_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCRouteTable_tags
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_overlapping
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCRouteTable_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCRouteTable_tags_EmptyMap
=== CONT  TestAccVPCRouteTable_tags_null
=== CONT  TestAccVPCRouteTable_tags_AddOnUpdate
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag (48.30s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag (48.68s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag (49.05s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag (49.34s)
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnCreate (50.00s)
--- PASS: TestAccVPCRouteTable_tags_null (54.84s)
--- PASS: TestAccVPCRouteTable_tags_EmptyMap (55.45s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_updateToProviderOnly (65.78s)
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add (67.38s)
--- PASS: TestAccVPCRouteTable_tags_AddOnUpdate (67.73s)
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace (68.01s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly (68.92s)
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace (69.00s)
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnCreate (69.42s)
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add (83.03s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping (91.78s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_overlapping (92.61s)
--- PASS: TestAccVPCRouteTable_tags (105.26s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_providerOnly (111.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	116.842s
% make t T=TestAccVPCSecurityGroupEgressRule_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupEgressRule_tags'  -timeout 360m
=== RUN   TestAccVPCSecurityGroupEgressRule_tags
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_null
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_null
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_EmptyMap
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_EmptyMap
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_AddOnUpdate
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_AddOnUpdate
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_overlapping
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroupEgressRule_tags
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_EmptyMap
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_overlapping
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_AddOnUpdate
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroupEgressRule_tags_null
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_EmptyMap (52.99s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullOverlappingResourceTag (58.53s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_null (58.70s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnCreate (58.70s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyProviderOnlyTag (58.72s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nullNonOverlappingResourceTag (59.84s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_emptyResourceTag (60.32s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_AddOnUpdate (85.63s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToResourceOnly (87.37s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Replace (89.28s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_updateToProviderOnly (89.47s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Replace (91.58s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_ComputedTag_OnUpdate_Add (92.83s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnCreate (94.45s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_EmptyTag_OnUpdate_Add (118.16s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_nonOverlapping (126.36s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_overlapping (128.82s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags (141.62s)
--- PASS: TestAccVPCSecurityGroupEgressRule_tags_DefaultTags_providerOnly (149.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	155.109s
% make t T=TestAccVPCSecurityGroup_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroup_tags'  -timeout 360m
=== RUN   TestAccVPCSecurityGroup_tags
=== PAUSE TestAccVPCSecurityGroup_tags
=== RUN   TestAccVPCSecurityGroup_tags_null
=== PAUSE TestAccVPCSecurityGroup_tags_null
=== RUN   TestAccVPCSecurityGroup_tags_EmptyMap
=== PAUSE TestAccVPCSecurityGroup_tags_EmptyMap
=== RUN   TestAccVPCSecurityGroup_tags_AddOnUpdate
=== PAUSE TestAccVPCSecurityGroup_tags_AddOnUpdate
=== RUN   TestAccVPCSecurityGroup_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCSecurityGroup_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_overlapping
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroup_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCSecurityGroup_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroup_tags
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroup_tags_EmptyMap
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSecurityGroup_tags_null
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroup_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCSecurityGroup_tags_AddOnUpdate
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCSecurityGroup_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCSecurityGroup_tags_DefaultTags_overlapping
=== CONT  TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_nullNonOverlappingResourceTag (49.35s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_emptyResourceTag (54.15s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_nullOverlappingResourceTag (54.15s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_emptyProviderOnlyTag (57.98s)
--- PASS: TestAccVPCSecurityGroup_tags_ComputedTag_OnCreate (58.50s)
--- PASS: TestAccVPCSecurityGroup_tags_null (64.76s)
--- PASS: TestAccVPCSecurityGroup_tags_EmptyMap (71.06s)
--- PASS: TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Replace (84.20s)
--- PASS: TestAccVPCSecurityGroup_tags_AddOnUpdate (88.62s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_updateToResourceOnly (92.96s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_updateToProviderOnly (93.82s)
--- PASS: TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Add (93.87s)
--- PASS: TestAccVPCSecurityGroup_tags_ComputedTag_OnUpdate_Replace (94.19s)
--- PASS: TestAccVPCSecurityGroup_tags_EmptyTag_OnCreate (94.56s)
--- PASS: TestAccVPCSecurityGroup_tags_EmptyTag_OnUpdate_Add (115.60s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_nonOverlapping (127.06s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_overlapping (127.55s)
--- PASS: TestAccVPCSecurityGroup_tags (144.38s)
--- PASS: TestAccVPCSecurityGroup_tags_DefaultTags_providerOnly (148.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	153.793s
% make t T=TestAccVPCVPC_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCVPC_tags'  -timeout 360m
=== RUN   TestAccVPCVPC_tags
=== PAUSE TestAccVPCVPC_tags
=== RUN   TestAccVPCVPC_tags_null
=== PAUSE TestAccVPCVPC_tags_null
=== RUN   TestAccVPCVPC_tags_EmptyMap
=== PAUSE TestAccVPCVPC_tags_EmptyMap
=== RUN   TestAccVPCVPC_tags_AddOnUpdate
=== PAUSE TestAccVPCVPC_tags_AddOnUpdate
=== RUN   TestAccVPCVPC_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCVPC_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCVPC_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCVPC_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCVPC_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCVPC_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCVPC_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCVPC_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCVPC_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCVPC_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCVPC_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCVPC_tags_DefaultTags_overlapping
=== RUN   TestAccVPCVPC_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCVPC_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCVPC_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCVPC_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCVPC_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCVPC_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCVPC_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCVPC_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCVPC_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCVPC_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCVPC_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCVPC_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCVPC_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCVPC_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCVPC_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCVPC_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCVPC_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCVPC_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCVPC_tags
=== CONT  TestAccVPCVPC_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCVPC_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCVPC_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCVPC_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCVPC_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCVPC_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCVPC_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCVPC_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCVPC_tags_AddOnUpdate
=== CONT  TestAccVPCVPC_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCVPC_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCVPC_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCVPC_tags_DefaultTags_overlapping
=== CONT  TestAccVPCVPC_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCVPC_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCVPC_tags_EmptyMap
=== CONT  TestAccVPCVPC_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCVPC_tags_null
--- PASS: TestAccVPCVPC_tags_DefaultTags_nullNonOverlappingResourceTag (44.14s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_emptyResourceTag (47.08s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_emptyProviderOnlyTag (47.23s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_nullOverlappingResourceTag (47.26s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnCreate (47.74s)
--- PASS: TestAccVPCVPC_tags_EmptyMap (55.26s)
--- PASS: TestAccVPCVPC_tags_null (56.28s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_updateToResourceOnly (62.40s)
--- PASS: TestAccVPCVPC_tags_AddOnUpdate (62.97s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_updateToProviderOnly (64.80s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnUpdate_Replace (67.05s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnUpdate_Replace (67.59s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnCreate (67.98s)
--- PASS: TestAccVPCVPC_tags_ComputedTag_OnUpdate_Add (68.01s)
--- PASS: TestAccVPCVPC_tags_EmptyTag_OnUpdate_Add (83.94s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_overlapping (93.01s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_nonOverlapping (93.32s)
--- PASS: TestAccVPCVPC_tags (107.07s)
--- PASS: TestAccVPCVPC_tags_DefaultTags_providerOnly (111.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	116.883s
% make t T=TestAccEC2Instance_BlockDeviceTags K=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_BlockDeviceTags'  -timeout 360m
=== RUN   TestAccEC2Instance_BlockDeviceTags_volumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_volumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== PAUSE TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== RUN   TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== RUN   TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
=== PAUSE TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== CONT  TestAccEC2Instance_BlockDeviceTags_attachedVolume
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags
=== CONT  TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsRBDOverlap (102.45s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsEBSRoot (106.05s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTagsOverlap (120.02s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (125.48s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (144.52s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsVolumeTags (146.25s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_attachedVolume (161.79s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_defaultTagsEBDOverlaps (319.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	324.983s
% make t T=TestAccVPCSecurityGroupDataSource_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupDataSource_tags'  -timeout 360m
=== RUN   TestAccVPCSecurityGroupDataSource_tags
=== PAUSE TestAccVPCSecurityGroupDataSource_tags
=== RUN   TestAccVPCSecurityGroupDataSource_tags_NullMap
=== PAUSE TestAccVPCSecurityGroupDataSource_tags_NullMap
=== RUN   TestAccVPCSecurityGroupDataSource_tags_EmptyMap
=== PAUSE TestAccVPCSecurityGroupDataSource_tags_EmptyMap
=== CONT  TestAccVPCSecurityGroupDataSource_tags
=== CONT  TestAccVPCSecurityGroupDataSource_tags_EmptyMap
=== CONT  TestAccVPCSecurityGroupDataSource_tags_NullMap
--- PASS: TestAccVPCSecurityGroupDataSource_tags (21.74s)
--- PASS: TestAccVPCSecurityGroupDataSource_tags_NullMap (21.84s)
--- PASS: TestAccVPCSecurityGroupDataSource_tags_EmptyMap (21.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.256s
% make t T=TestAccVPCSecurityGroupIngressRule_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupIngressRule_tags'  -timeout 360m
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_null
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_null
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_EmptyMap
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_EmptyMap
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_AddOnUpdate
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_AddOnUpdate
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_overlapping
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_tags_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags_ignoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_overlapping
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_AddOnUpdate
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_null
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_defaultAndIgnoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_ignoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullNonOverlappingResourceTag (71.38s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags_EmptyMap
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_null (74.81s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyResourceTag (74.81s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnCreate (75.30s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nullOverlappingResourceTag (76.06s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_emptyProviderOnlyTag (76.39s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_ignoreTags (90.41s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_defaultAndIgnoreTags (90.98s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_AddOnUpdate (95.36s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToResourceOnly (98.42s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Replace (98.43s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_updateToProviderOnly (98.45s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnCreate (100.57s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Replace (100.89s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_ComputedTag_OnUpdate_Add (101.14s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_EmptyMap (35.55s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_EmptyTag_OnUpdate_Add (116.75s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_overlapping (125.88s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_nonOverlapping (126.15s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (136.78s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags_DefaultTags_providerOnly (145.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	151.022s
% make t T=TestAccVPCSubnet_tags K=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnet_tags'  -timeout 360m
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPCSubnet_tags_null
=== PAUSE TestAccVPCSubnet_tags_null
=== RUN   TestAccVPCSubnet_tags_EmptyMap
=== PAUSE TestAccVPCSubnet_tags_EmptyMap
=== RUN   TestAccVPCSubnet_tags_AddOnUpdate
=== PAUSE TestAccVPCSubnet_tags_AddOnUpdate
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCSubnet_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCSubnet_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_overlapping
=== RUN   TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCSubnet_tags_defaultAndIgnoreTags
=== PAUSE TestAccVPCSubnet_tags_defaultAndIgnoreTags
=== RUN   TestAccVPCSubnet_tags_ignoreTags
=== PAUSE TestAccVPCSubnet_tags_ignoreTags
=== CONT  TestAccVPCSubnet_tags
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCSubnet_tags_AddOnUpdate
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnCreate
=== CONT  TestAccVPCSubnet_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nonOverlapping
=== CONT  TestAccVPCSubnet_tags_defaultAndIgnoreTags
=== CONT  TestAccVPCSubnet_tags_ignoreTags
=== CONT  TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSubnet_tags_DefaultTags_overlapping
=== CONT  TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCSubnet_tags_EmptyMap
=== CONT  TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSubnet_tags_null
--- PASS: TestAccVPCSubnet_tags_DefaultTags_emptyProviderOnlyTag (71.53s)
=== CONT  TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nullNonOverlappingResourceTag (72.35s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_emptyResourceTag (72.41s)
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnCreate (72.58s)
--- PASS: TestAccVPCSubnet_tags_null (83.29s)
--- PASS: TestAccVPCSubnet_tags_EmptyMap (83.93s)
--- PASS: TestAccVPCSubnet_tags_defaultAndIgnoreTags (84.58s)
--- PASS: TestAccVPCSubnet_tags_ignoreTags (85.79s)
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Replace (92.96s)
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Replace (94.11s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_updateToResourceOnly (94.50s)
--- PASS: TestAccVPCSubnet_tags_AddOnUpdate (95.44s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_updateToProviderOnly (96.02s)
--- PASS: TestAccVPCSubnet_tags_ComputedTag_OnUpdate_Add (96.28s)
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnCreate (99.30s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nullOverlappingResourceTag (32.90s)
--- PASS: TestAccVPCSubnet_tags_EmptyTag_OnUpdate_Add (113.95s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_nonOverlapping (119.58s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_overlapping (120.79s)
--- PASS: TestAccVPCSubnet_tags (135.92s)
--- PASS: TestAccVPCSubnet_tags_DefaultTags_providerOnly (139.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	145.758s
% make t T=TestAccDynamoDBTable_tags K=dynamodb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_tags'  -timeout 360m
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_tags_null
=== PAUSE TestAccDynamoDBTable_tags_null
=== RUN   TestAccDynamoDBTable_tags_EmptyMap
=== PAUSE TestAccDynamoDBTable_tags_EmptyMap
=== RUN   TestAccDynamoDBTable_tags_AddOnUpdate
=== PAUSE TestAccDynamoDBTable_tags_AddOnUpdate
=== RUN   TestAccDynamoDBTable_tags_EmptyTag_OnCreate
=== PAUSE TestAccDynamoDBTable_tags_EmptyTag_OnCreate
=== RUN   TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_providerOnly
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_providerOnly
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_nonOverlapping
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_overlapping
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_overlapping
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccDynamoDBTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccDynamoDBTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccDynamoDBTable_tags_ComputedTag_OnCreate
=== PAUSE TestAccDynamoDBTable_tags_ComputedTag_OnCreate
=== RUN   TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccDynamoDBTable_tags
=== CONT  TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccDynamoDBTable_tags_ComputedTag_OnCreate
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccDynamoDBTable_tags_null
=== CONT  TestAccDynamoDBTable_tags_AddOnUpdate
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_overlapping
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_providerOnly
=== CONT  TestAccDynamoDBTable_tags_EmptyMap
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccDynamoDBTable_tags_EmptyTag_OnCreate
=== CONT  TestAccDynamoDBTable_tags_DefaultTags_nonOverlapping
=== CONT  TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_nullNonOverlappingResourceTag (51.86s)
--- PASS: TestAccDynamoDBTable_tags_ComputedTag_OnCreate (53.00s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_emptyResourceTag (53.49s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_emptyProviderOnlyTag (54.49s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_nullOverlappingResourceTag (54.82s)
--- PASS: TestAccDynamoDBTable_tags_null (58.34s)
--- PASS: TestAccDynamoDBTable_tags_EmptyMap (59.47s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_updateToResourceOnly (64.52s)
--- PASS: TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Replace (70.94s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_updateToProviderOnly (70.94s)
--- PASS: TestAccDynamoDBTable_tags_AddOnUpdate (73.11s)
--- PASS: TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Add (75.28s)
--- PASS: TestAccDynamoDBTable_tags_ComputedTag_OnUpdate_Replace (76.93s)
--- PASS: TestAccDynamoDBTable_tags_EmptyTag_OnCreate (78.07s)
--- PASS: TestAccDynamoDBTable_tags_EmptyTag_OnUpdate_Add (87.92s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_nonOverlapping (103.88s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_overlapping (105.67s)
--- PASS: TestAccDynamoDBTable_tags_DefaultTags_providerOnly (120.42s)
--- PASS: TestAccDynamoDBTable_tags (126.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	132.130s
% make t T=TestAccIAMPolicy_tags K=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMPolicy_tags'  -timeout 360m
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_tags_null
=== PAUSE TestAccIAMPolicy_tags_null
=== RUN   TestAccIAMPolicy_tags_EmptyMap
=== PAUSE TestAccIAMPolicy_tags_EmptyMap
=== RUN   TestAccIAMPolicy_tags_AddOnUpdate
=== PAUSE TestAccIAMPolicy_tags_AddOnUpdate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMPolicy_tags
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMPolicy_tags_EmptyMap
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== CONT  TestAccIAMPolicy_tags_null
=== CONT  TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMPolicy_tags_DefaultTags_overlapping
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (39.70s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (43.35s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnCreate (46.12s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (64.41s)
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (66.00s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (75.71s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace (79.70s)
--- PASS: TestAccIAMPolicy_tags_null (89.30s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (92.43s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add (100.01s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag (100.40s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (107.42s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (108.80s)
--- PASS: TestAccIAMPolicy_tags_EmptyMap (111.21s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (130.19s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (131.57s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (133.46s)
--- PASS: TestAccIAMPolicy_tags (138.88s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (159.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	164.811s
% make t T=TestAccIAMRole_tags K=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMRole_tags'  -timeout 360m
=== RUN   TestAccIAMRole_tags
=== PAUSE TestAccIAMRole_tags
=== RUN   TestAccIAMRole_tags_null
=== PAUSE TestAccIAMRole_tags_null
=== RUN   TestAccIAMRole_tags_EmptyMap
=== PAUSE TestAccIAMRole_tags_EmptyMap
=== RUN   TestAccIAMRole_tags_AddOnUpdate
=== PAUSE TestAccIAMRole_tags_AddOnUpdate
=== RUN   TestAccIAMRole_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMRole_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMRole_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMRole_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMRole_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMRole_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMRole_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMRole_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMRole_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMRole_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMRole_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMRole_tags_DefaultTags_overlapping
=== RUN   TestAccIAMRole_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMRole_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMRole_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMRole_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMRole_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMRole_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMRole_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMRole_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMRole_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMRole_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMRole_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMRole_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMRole_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMRole_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMRole_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMRole_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMRole_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMRole_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMRole_tags
=== CONT  TestAccIAMRole_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccIAMRole_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMRole_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMRole_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMRole_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMRole_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccIAMRole_tags_ComputedTag_OnCreate
=== CONT  TestAccIAMRole_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMRole_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMRole_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMRole_tags_AddOnUpdate
=== CONT  TestAccIAMRole_tags_EmptyMap
=== CONT  TestAccIAMRole_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMRole_tags_DefaultTags_overlapping
=== CONT  TestAccIAMRole_tags_null
=== CONT  TestAccIAMRole_tags_DefaultTags_nonOverlapping
=== CONT  TestAccIAMRole_tags_DefaultTags_providerOnly
=== CONT  TestAccIAMRole_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMRole_tags_DefaultTags_emptyProviderOnlyTag (70.23s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nullOverlappingResourceTag (71.52s)
--- PASS: TestAccIAMRole_tags_ComputedTag_OnCreate (71.55s)
--- PASS: TestAccIAMRole_tags_DefaultTags_emptyResourceTag (71.86s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nullNonOverlappingResourceTag (72.29s)
--- PASS: TestAccIAMRole_tags_null (82.10s)
--- PASS: TestAccIAMRole_tags_EmptyMap (82.41s)
--- PASS: TestAccIAMRole_tags_DefaultTags_updateToResourceOnly (90.32s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnUpdate_Replace (90.65s)
--- PASS: TestAccIAMRole_tags_DefaultTags_updateToProviderOnly (92.57s)
--- PASS: TestAccIAMRole_tags_AddOnUpdate (92.63s)
--- PASS: TestAccIAMRole_tags_ComputedTag_OnUpdate_Replace (94.13s)
--- PASS: TestAccIAMRole_tags_ComputedTag_OnUpdate_Add (95.51s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnCreate (95.86s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnUpdate_Add (107.90s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nonOverlapping (111.71s)
--- PASS: TestAccIAMRole_tags_DefaultTags_overlapping (112.98s)
--- PASS: TestAccIAMRole_tags (122.93s)
--- PASS: TestAccIAMRole_tags_DefaultTags_providerOnly (126.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	131.636s
% make t T=TestAccLambdaFunction_tags K=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_tags'  -timeout 360m
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_tags_null
=== PAUSE TestAccLambdaFunction_tags_null
=== RUN   TestAccLambdaFunction_tags_EmptyMap
=== PAUSE TestAccLambdaFunction_tags_EmptyMap
=== RUN   TestAccLambdaFunction_tags_AddOnUpdate
=== PAUSE TestAccLambdaFunction_tags_AddOnUpdate
=== RUN   TestAccLambdaFunction_tags_EmptyTag_OnCreate
=== PAUSE TestAccLambdaFunction_tags_EmptyTag_OnCreate
=== RUN   TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLambdaFunction_tags_DefaultTags_providerOnly
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_providerOnly
=== RUN   TestAccLambdaFunction_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLambdaFunction_tags_DefaultTags_overlapping
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_overlapping
=== RUN   TestAccLambdaFunction_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLambdaFunction_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLambdaFunction_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLambdaFunction_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLambdaFunction_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLambdaFunction_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLambdaFunction_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLambdaFunction_tags_ComputedTag_OnCreate
=== PAUSE TestAccLambdaFunction_tags_ComputedTag_OnCreate
=== RUN   TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccLambdaFunction_tags
=== CONT  TestAccLambdaFunction_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccLambdaFunction_tags_DefaultTags_overlapping
=== CONT  TestAccLambdaFunction_tags_DefaultTags_nonOverlapping
=== CONT  TestAccLambdaFunction_tags_DefaultTags_providerOnly
=== CONT  TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccLambdaFunction_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccLambdaFunction_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccLambdaFunction_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccLambdaFunction_tags_ComputedTag_OnCreate
=== CONT  TestAccLambdaFunction_tags_AddOnUpdate
=== CONT  TestAccLambdaFunction_tags_EmptyTag_OnCreate
=== CONT  TestAccLambdaFunction_tags_EmptyMap
=== CONT  TestAccLambdaFunction_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccLambdaFunction_tags_null
=== CONT  TestAccLambdaFunction_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccLambdaFunction_tags_DefaultTags_nullOverlappingResourceTag (47.95s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_nullNonOverlappingResourceTag (54.28s)
--- PASS: TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Add (57.54s)
--- PASS: TestAccLambdaFunction_tags_ComputedTag_OnCreate (61.85s)
--- PASS: TestAccLambdaFunction_tags_AddOnUpdate (79.64s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_emptyResourceTag (85.65s)
--- PASS: TestAccLambdaFunction_tags_ComputedTag_OnUpdate_Replace (88.70s)
--- PASS: TestAccLambdaFunction_tags_EmptyMap (104.09s)
--- PASS: TestAccLambdaFunction_tags_EmptyTag_OnCreate (108.39s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_emptyProviderOnlyTag (111.32s)
--- PASS: TestAccLambdaFunction_tags_null (122.97s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_providerOnly (131.43s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_updateToResourceOnly (136.97s)
--- PASS: TestAccLambdaFunction_tags (155.18s)
--- PASS: TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Replace (155.68s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_updateToProviderOnly (162.64s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_overlapping (165.12s)
--- PASS: TestAccLambdaFunction_tags_EmptyTag_OnUpdate_Add (165.52s)
--- PASS: TestAccLambdaFunction_tags_DefaultTags_nonOverlapping (188.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	193.446s

@YakDriver YakDriver merged commit c67d239 into hashicorp:main Oct 9, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet