-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MeshServiceDiscovery to MeshSpec in App Mesh #37042
Add MeshServiceDiscovery to MeshSpec in App Mesh #37042
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ph-l 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppMesh_serial/Mesh' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/Mesh -timeout 360m
=== RUN TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT TestAccAppMesh_serial
=== RUN TestAccAppMesh_serial/Mesh
=== RUN TestAccAppMesh_serial/Mesh/disappears
=== RUN TestAccAppMesh_serial/Mesh/serviceDiscovery
=== RUN TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
=== RUN TestAccAppMesh_serial/Mesh/dataSourceShared
mesh_data_source_test.go:116: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN TestAccAppMesh_serial/Mesh/basic
=== RUN TestAccAppMesh_serial/Mesh/egressFilter
=== RUN TestAccAppMesh_serial/Mesh/tags
=== RUN TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
--- PASS: TestAccAppMesh_serial (253.90s)
--- PASS: TestAccAppMesh_serial/Mesh (253.90s)
--- PASS: TestAccAppMesh_serial/Mesh/disappears (33.67s)
--- PASS: TestAccAppMesh_serial/Mesh/serviceDiscovery (64.37s)
--- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (16.40s)
--- SKIP: TestAccAppMesh_serial/Mesh/dataSourceShared (0.00s)
--- PASS: TestAccAppMesh_serial/Mesh/basic (18.25s)
--- PASS: TestAccAppMesh_serial/Mesh/egressFilter (42.27s)
--- PASS: TestAccAppMesh_serial/Mesh/tags (45.87s)
--- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (16.58s)
--- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (16.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 270.821s
@ph-l Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the serviceDiscovery object in the specification of a service mesh for App Mesh.
Relations
Closes #37034
References
https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_MeshSpec.html
Output from Acceptance Testing