Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add use_off_peak_window arg to auto_tune_options block for aws_opensearch_domain #36067

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Mar 4, 2024

Description

This PR is to add a new use_off_peak_window argument to the auto_tune_options configuration block for the aws_opensearch_domain resource. To make this work, I had to remove Computed: true from the maintenance_schedule config block schema, otherwise it would keep loading the existing config blocks even though they are removed from the TF config in an update scenario.

Relations

Closes #33208

References

Referred to CreateDomain and UpdateDomainConfig for the specs and description.

Output from Acceptance Testing

$  make testacc TESTARGS="-run=TestAccOpenSearchDomain_autoTuneOptions" PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomain_autoTuneOptions -timeout 360m
=== RUN   TestAccOpenSearchDomain_autoTuneOptions
=== PAUSE TestAccOpenSearchDomain_autoTuneOptions
=== CONT  TestAccOpenSearchDomain_autoTuneOptions
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (1775.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 1775.767s

$

Copy link

github-actions bot commented Mar 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearch Issues and PRs that pertain to the opensearch service. labels Mar 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2024
@acwwat acwwat force-pushed the f-aws_opensearch_domain-add_use_off_peak_window_arg branch from a446792 to c8a219f Compare March 4, 2024 10:36
@acwwat acwwat changed the title [WIP] feat: Add use_off_peak_window arg to auto_tune_options block for aws_opensearch_domain feat: Add use_off_peak_window arg to auto_tune_options block for aws_opensearch_domain Mar 4, 2024
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 4, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 5, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomain_autoTuneOptions\|TestAccOpenSearchDomain_basic' PKG=opensearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchDomain_autoTuneOptions\|TestAccOpenSearchDomain_basic -timeout 360m
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_autoTuneOptions
=== PAUSE TestAccOpenSearchDomain_autoTuneOptions
=== CONT  TestAccOpenSearchDomain_basic
=== CONT  TestAccOpenSearchDomain_autoTuneOptions
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (1813.36s)
--- PASS: TestAccOpenSearchDomain_basic (2069.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2077.928s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a4c5c50 into hashicorp:main Mar 5, 2024
62 checks passed
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 5, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@xfournet
Copy link

@acwwat unfortunately it looks like this PR introduces this regression: #36291

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/opensearch Issues and PRs that pertain to the opensearch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants