-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_secretsmanager_*
- migrate to aws-sdk-go-v2
#35174
aws_secretsmanager_*
- migrate to aws-sdk-go-v2
#35174
Conversation
… secret and updated the doc
aws_secretsmanager_secret_rotation `rotate_immediatley`
Community NoteVoting for Prioritization
For Submitters
|
r/aws_secretsmanager
- migrate to aws-sdk-go-v2
r/aws_secretsmanager_*
- migrate to aws-sdk-go-v2
r/aws_secretsmanager_*
- migrate to aws-sdk-go-v2
aws_secretsmanager_*
- migrate to aws-sdk-go-v2
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
73159c2
to
c8725f6
Compare
…cSecretsManagerSecret_disappears'.
… into HEAD # Conflicts: # internal/service/secretsmanager/secret_data_source.go # internal/service/secretsmanager/secret_version_data_source.go
…nto HEAD # Conflicts: # internal/service/secretsmanager/secret_rotation.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSecretsManager' PKG=secretsmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManager -timeout 360m
=== RUN TestAccSecretsManagerRandomPasswordDataSource_basic
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_basic
=== RUN TestAccSecretsManagerRandomPasswordDataSource_exclude
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_exclude
=== RUN TestAccSecretsManagerSecretDataSource_basic
=== PAUSE TestAccSecretsManagerSecretDataSource_basic
=== RUN TestAccSecretsManagerSecretDataSource_arn
=== PAUSE TestAccSecretsManagerSecretDataSource_arn
=== RUN TestAccSecretsManagerSecretDataSource_name
=== PAUSE TestAccSecretsManagerSecretDataSource_name
=== RUN TestAccSecretsManagerSecretDataSource_policy
=== PAUSE TestAccSecretsManagerSecretDataSource_policy
=== RUN TestAccSecretsManagerSecretPolicy_basic
=== PAUSE TestAccSecretsManagerSecretPolicy_basic
=== RUN TestAccSecretsManagerSecretPolicy_blockPublicPolicy
=== PAUSE TestAccSecretsManagerSecretPolicy_blockPublicPolicy
=== RUN TestAccSecretsManagerSecretPolicy_disappears
=== PAUSE TestAccSecretsManagerSecretPolicy_disappears
=== RUN TestAccSecretsManagerSecretPolicy_Disappears_secret
=== PAUSE TestAccSecretsManagerSecretPolicy_Disappears_secret
=== RUN TestAccSecretsManagerSecretRotationDataSource_basic
=== PAUSE TestAccSecretsManagerSecretRotationDataSource_basic
=== RUN TestAccSecretsManagerSecretRotation_basic
=== PAUSE TestAccSecretsManagerSecretRotation_basic
=== RUN TestAccSecretsManagerSecretRotation_upgradePreRotateImmediately
=== PAUSE TestAccSecretsManagerSecretRotation_upgradePreRotateImmediately
=== RUN TestAccSecretsManagerSecretRotation_rotateImmediately
=== PAUSE TestAccSecretsManagerSecretRotation_rotateImmediately
=== RUN TestAccSecretsManagerSecretRotation_disappears
=== PAUSE TestAccSecretsManagerSecretRotation_disappears
=== RUN TestAccSecretsManagerSecretRotation_Disappears_secret
=== PAUSE TestAccSecretsManagerSecretRotation_Disappears_secret
=== RUN TestAccSecretsManagerSecretRotation_scheduleExpression
=== PAUSE TestAccSecretsManagerSecretRotation_scheduleExpression
=== RUN TestAccSecretsManagerSecretRotation_scheduleExpressionToDays
=== PAUSE TestAccSecretsManagerSecretRotation_scheduleExpressionToDays
=== RUN TestAccSecretsManagerSecretRotation_scheduleExpressionHours
=== PAUSE TestAccSecretsManagerSecretRotation_scheduleExpressionHours
=== RUN TestAccSecretsManagerSecretRotation_duration
=== PAUSE TestAccSecretsManagerSecretRotation_duration
=== RUN TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN TestAccSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccSecretsManagerSecret_withNamePrefix
=== RUN TestAccSecretsManagerSecret_disappears
=== PAUSE TestAccSecretsManagerSecret_disappears
=== RUN TestAccSecretsManagerSecret_description
=== PAUSE TestAccSecretsManagerSecret_description
=== RUN TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== RUN TestAccSecretsManagerSecret_overwriteReplica
=== PAUSE TestAccSecretsManagerSecret_overwriteReplica
=== RUN TestAccSecretsManagerSecret_kmsKeyID
=== PAUSE TestAccSecretsManagerSecret_kmsKeyID
=== RUN TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== PAUSE TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== RUN TestAccSecretsManagerSecret_tags
=== PAUSE TestAccSecretsManagerSecret_tags
=== RUN TestAccSecretsManagerSecret_policy
=== PAUSE TestAccSecretsManagerSecret_policy
=== RUN TestAccSecretsManagerSecretVersionDataSource_basic
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_basic
=== RUN TestAccSecretsManagerSecretVersionDataSource_versionID
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_versionID
=== RUN TestAccSecretsManagerSecretVersionDataSource_versionStage
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_versionStage
=== RUN TestAccSecretsManagerSecretVersion_basicString
=== PAUSE TestAccSecretsManagerSecretVersion_basicString
=== RUN TestAccSecretsManagerSecretVersion_base64Binary
=== PAUSE TestAccSecretsManagerSecretVersion_base64Binary
=== RUN TestAccSecretsManagerSecretVersion_versionStages
=== PAUSE TestAccSecretsManagerSecretVersion_versionStages
=== RUN TestAccSecretsManagerSecretVersion_disappears
=== PAUSE TestAccSecretsManagerSecretVersion_disappears
=== RUN TestAccSecretsManagerSecretVersion_Disappears_secret
=== PAUSE TestAccSecretsManagerSecretVersion_Disappears_secret
=== RUN TestAccSecretsManagerSecretsDataSource_filter
=== PAUSE TestAccSecretsManagerSecretsDataSource_filter
=== CONT TestAccSecretsManagerRandomPasswordDataSource_basic
=== CONT TestAccSecretsManagerSecret_policy
=== CONT TestAccSecretsManagerSecretVersion_base64Binary
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_basic (13.96s)
=== CONT TestAccSecretsManagerSecretVersion_disappears
--- PASS: TestAccSecretsManagerSecretVersion_base64Binary (24.00s)
=== CONT TestAccSecretsManagerSecretVersion_versionStages
--- PASS: TestAccSecretsManagerSecretVersion_disappears (20.49s)
=== CONT TestAccSecretsManagerSecretVersion_Disappears_secret
--- PASS: TestAccSecretsManagerSecretVersion_Disappears_secret (21.75s)
=== CONT TestAccSecretsManagerSecretsDataSource_filter
--- PASS: TestAccSecretsManagerSecret_policy (62.02s)
=== CONT TestAccSecretsManagerSecretPolicy_disappears
--- PASS: TestAccSecretsManagerSecretVersion_versionStages (53.53s)
=== CONT TestAccSecretsManagerSecretRotation_Disappears_secret
--- PASS: TestAccSecretsManagerSecretPolicy_disappears (26.35s)
=== CONT TestAccSecretsManagerSecret_tags
--- PASS: TestAccSecretsManagerSecretsDataSource_filter (59.43s)
=== CONT TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
--- PASS: TestAccSecretsManagerSecretRotation_Disappears_secret (45.29s)
=== CONT TestAccSecretsManagerSecretRotation_disappears
--- PASS: TestAccSecretsManagerSecret_tags (45.65s)
=== CONT TestAccSecretsManagerSecret_kmsKeyID
--- PASS: TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate (34.53s)
=== CONT TestAccSecretsManagerSecretRotation_rotateImmediately
--- PASS: TestAccSecretsManagerSecretRotation_disappears (44.67s)
=== CONT TestAccSecretsManagerSecret_overwriteReplica
--- PASS: TestAccSecretsManagerSecret_kmsKeyID (35.46s)
=== CONT TestAccSecretsManagerSecretRotation_upgradePreRotateImmediately
--- PASS: TestAccSecretsManagerSecretRotation_rotateImmediately (51.33s)
=== CONT TestAccSecretsManagerSecret_basicReplica
--- PASS: TestAccSecretsManagerSecret_basicReplica (24.60s)
=== CONT TestAccSecretsManagerSecretRotation_basic
--- PASS: TestAccSecretsManagerSecret_overwriteReplica (85.70s)
=== CONT TestAccSecretsManagerSecretRotationDataSource_basic
--- PASS: TestAccSecretsManagerSecretRotation_basic (46.22s)
=== CONT TestAccSecretsManagerSecretPolicy_Disappears_secret
--- PASS: TestAccSecretsManagerSecretRotation_upgradePreRotateImmediately (105.18s)
=== CONT TestAccSecretsManagerSecretDataSource_name
--- PASS: TestAccSecretsManagerSecretDataSource_name (16.07s)
=== CONT TestAccSecretsManagerSecret_description
--- PASS: TestAccSecretsManagerSecretRotationDataSource_basic (45.37s)
=== CONT TestAccSecretsManagerSecretPolicy_blockPublicPolicy
--- PASS: TestAccSecretsManagerSecretPolicy_Disappears_secret (26.58s)
=== CONT TestAccSecretsManagerSecret_disappears
--- PASS: TestAccSecretsManagerSecret_disappears (18.04s)
=== CONT TestAccSecretsManagerSecretPolicy_basic
--- PASS: TestAccSecretsManagerSecret_description (33.40s)
=== CONT TestAccSecretsManagerSecret_withNamePrefix
--- PASS: TestAccSecretsManagerSecret_withNamePrefix (22.78s)
=== CONT TestAccSecretsManagerSecretDataSource_policy
--- PASS: TestAccSecretsManagerSecretPolicy_blockPublicPolicy (58.15s)
=== CONT TestAccSecretsManagerSecret_basic
--- PASS: TestAccSecretsManagerSecretPolicy_basic (45.66s)
=== CONT TestAccSecretsManagerSecretVersionDataSource_versionStage
--- PASS: TestAccSecretsManagerSecretDataSource_policy (19.21s)
=== CONT TestAccSecretsManagerSecretVersion_basicString
--- PASS: TestAccSecretsManagerSecret_basic (22.08s)
=== CONT TestAccSecretsManagerSecretDataSource_basic
--- PASS: TestAccSecretsManagerSecretVersionDataSource_versionStage (19.30s)
=== CONT TestAccSecretsManagerSecretDataSource_arn
--- PASS: TestAccSecretsManagerSecretDataSource_basic (6.71s)
=== CONT TestAccSecretsManagerSecretRotation_duration
--- PASS: TestAccSecretsManagerSecretVersion_basicString (22.49s)
=== CONT TestAccSecretsManagerSecretVersionDataSource_versionID
--- PASS: TestAccSecretsManagerSecretDataSource_arn (17.60s)
=== CONT TestAccSecretsManagerSecretVersionDataSource_basic
--- PASS: TestAccSecretsManagerSecretVersionDataSource_versionID (17.58s)
=== CONT TestAccSecretsManagerSecretRotation_scheduleExpressionToDays
--- PASS: TestAccSecretsManagerSecretVersionDataSource_basic (18.86s)
=== CONT TestAccSecretsManagerSecretRotation_scheduleExpressionHours
--- PASS: TestAccSecretsManagerSecretRotation_duration (46.01s)
=== CONT TestAccSecretsManagerSecretRotation_scheduleExpression
--- PASS: TestAccSecretsManagerSecretRotation_scheduleExpressionToDays (60.70s)
=== CONT TestAccSecretsManagerRandomPasswordDataSource_exclude
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_exclude (13.77s)
--- PASS: TestAccSecretsManagerSecretRotation_scheduleExpressionHours (63.88s)
--- PASS: TestAccSecretsManagerSecretRotation_scheduleExpression (59.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 497.079s
@aristosvo Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Update of
secretsmanager
package to AWS Go SDK to v2namevaluesfilters
generation is split into a newnamevaluesfiltersv2
versionRelations
Relates #32467.
Relates #32917.
Closes #35172.
Closes #35117.
Closes #34602.
Closes #35105.
Closes #34961.
References
Output from Acceptance Testing