Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(efs_file_system): lifecycle_policy transition_to_archive #35096

Merged
merged 4 commits into from
Jan 3, 2024
Merged

feat(efs_file_system): lifecycle_policy transition_to_archive #35096

merged 4 commits into from
Jan 3, 2024

Conversation

EttoreFoti
Copy link

@EttoreFoti EttoreFoti commented Dec 29, 2023

Description

Implement transition_to_archive lifecycle policy in efs_file_system.

Relations

Closes #35082

make testacc TESTARGS="-run=TestAccEFSFileSystem_lifecyclePolicy\|TestAccEFSFileSystemDataSource_id" PKG=efs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20  -run=TestAccEFSFileSystem_lifecyclePolicy\|TestAccEFSFileSystemDataSource_id -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== CONT  TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystemDataSource_id (31.59s)
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (101.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        103.811s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. labels Dec 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 29, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2024
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEFSFileSystem_lifecyclePolicy\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id' PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2  -run=TestAccEFSFileSystem_lifecyclePolicy\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== CONT  TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystemDataSource_id (25.33s)
=== CONT  TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_basic (29.13s)
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (81.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	87.283s

@ewbankkit
Copy link
Contributor

@EttoreFoti Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 076ba95 into hashicorp:main Jan 3, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 3, 2024
@EttoreFoti EttoreFoti deleted the e-efs_filesystem_transition_to_archive branch January 8, 2024 10:11
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow setting "transition_to_archive"
2 participants